Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDL::NetCDF #6

Open
cbrownstevenson opened this issue Oct 6, 2022 · 5 comments
Open

PDL::NetCDF #6

cbrownstevenson opened this issue Oct 6, 2022 · 5 comments

Comments

@cbrownstevenson
Copy link

In the PDL::NetCDF module, in typemap3. Unsigned PDL::byte are being mapped to NC_BYTE () - signed. Shouldn't be NC_UBYTE().

PDL's signed byte type is sbyte
NetCDF.pm line 930

@mohawk2 mohawk2 transferred this issue from PDLPorters/pdl Oct 7, 2022
@mohawk2
Copy link
Member

mohawk2 commented Oct 7, 2022

PDL does indeed support sbyte, but only as of 2.064. This library currently supports PDL 2.019 and above. @doughunt Would you be Ok with increasing the minimum PDL to 2.064?

@cbrownstevenson
Copy link
Author

cbrownstevenson commented Oct 7, 2022

@mohawk2 the version that I am seeing on NetCDF.pm is 4.20. Ah, but the PDL version is 2.020.

@mohawk2
Copy link
Member

mohawk2 commented Oct 8, 2022

@cbrownstevenson That suggests your installed version of PDL doesn't have sbyte, which means you'd have to upgrade your PDL to get the benefit of such a change?

@doughunt
Copy link
Collaborator

doughunt commented Oct 8, 2022 via email

@mohawk2
Copy link
Member

mohawk2 commented Oct 8, 2022

If it helps, PDL 2.080 looks very solid on CPAN Testers (https://www.cpantesters.org/distro/P/PDL.html?oncpan=1&distmat=1&version=2.080&grade=2) with the exception of BSD, which has older and buggy versions of clang, which PDL now triggers those bugs and crashes the compiler. With GCC, or more recent clang, it seems to work well.

Therefore, it appears to me (subject to proper testing for your application), that upgrading to PDL 2.080 should not cause failures or downtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants