Upgrade gradlew from 8.1.1 to 8.3 #6923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved warnings in build.gradle and distribution.gradle, telling about "Deprecated access to plugin conventions" that will be removed in Gradle 9.0 Signed-off-by: Vest <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved warnings in build.gradle and distribution.gradle, telling about "Deprecated access to plugin conventions" that will be removed in Gradle 9.0
More details about the actual change are available on Gradle docs website: here and there. Gradle warned me many times, so I have decided to take a deep breath and implement the recommended changes with the help from SO.
Regarding the consequences - I haven't found them. I was able to build the distribution of PCGen on my Windows machine without any errors (it took approximately 26 minutes on battery). The second thing that I found out is that (probably Tom) left a comment regarding NetBeans and its "strange" behavior. Honestly speaking, NetBeans 18 couldn't open and build both projects (before my change, the old one, and after my change, the new one). So I have decided to remove the code that probably is outdated. If you have issues with NetBeans that you never had before, feel free to correct, or kick me. Probably this thing worked in the past, but not in 2023.
Ok, I think, that's all. Feel free to test the patch on your machines. You can see the warnings in your current working directory if you start gradlew with
--warning-mode=all, e.g.,gradlew --warning-mode=allon Windows.