Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover and finish the work done on PR #25 #47

Open
ar9708 opened this issue May 13, 2024 · 2 comments
Open

Recover and finish the work done on PR #25 #47

ar9708 opened this issue May 13, 2024 · 2 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@ar9708
Copy link
Contributor

ar9708 commented May 13, 2024

Please @mykhailodanilenko, can you recover the "lost PR" #25 and complete it? The student Viktor who were working on it is no longer with us.

Please give credits to OGTor by re-using his commits, not just copying the images.

@ar9708 ar9708 added the help wanted Extra attention is needed label May 13, 2024
@mykhailodanilenko
Copy link
Collaborator

@ar9708 I think the more recent developments on this issue are in Viktor's other PR #46, I should work with that instead (the branch for #25 is completely deleted btw)

@ar9708
Copy link
Contributor Author

ar9708 commented May 13, 2024

@ar9708 I think the more recent developments on this issue are in Viktor's other PR #46, I should work with that instead (the branch for #25 is completely deleted btw)

Yeah, I see what you mean, it was probably not the best idea to delete the entire repo. However, as you indicate, from looking at the GitHub PR views it looks like #46 have all the important graphics stuff to recover the essentials:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants