Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styler package #498

Open
wibeasley opened this issue Jul 14, 2023 · 1 comment
Open

styler package #498

wibeasley opened this issue Jul 14, 2023 · 1 comment
Assignees

Comments

@wibeasley
Copy link
Member

@gabrielodom & @RaymondBalise suggested I also use the styler package, in addition to lintr, goodpractice, & BiocCheck.

I like most of its suggestions. Maybe I can loosen up its alignment standards (eg,

I like this

status_code <- response$status
success     <- (status_code == 200L)
raw_text    <- httr::content(

vs this

status_code <- response$status
success <- (status_code == 200L)
raw_text <- httr::content(

)

@wibeasley wibeasley self-assigned this Jul 14, 2023
wibeasley added a commit that referenced this issue Jul 14, 2023
@gabrielodom
Copy link

To me, there should be some flexibility here, especially if some of your names are quite longer than others. So, I agree with your example above, but in this example below I would not. That is, I prefer this:

aSuperLongComplicatedNameThatProbablyShouldBeMuchShorterButWhoCares <- f(x)
shortName <- g(x)

to this:

aSuperLongComplicatedNameThatProbablyShouldBeMuchShorterButWhoCares <- f(x)
shortName  ........................................................ <- g(x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants