Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider related stuff #51

Open
ArjixWasTaken opened this issue Feb 18, 2021 · 3 comments
Open

Provider related stuff #51

ArjixWasTaken opened this issue Feb 18, 2021 · 3 comments

Comments

@ArjixWasTaken
Copy link

So, we have no way to contact each other, that's why I am making an issue where we can discuss on provider related stuff.

First of all,
Since you are using cloudscraper, and the requests library is a dependency for cloudscraper,
That means that I can directly Import the requests library, right?
Using a session for simple api calls (the provider im working on) sounds like a pain.

Also, I suggest writing wrapper functions in the util file, that way we can use smth like util.soup(html) for parsing html or util.get(link) and util.post(link, data) for requests that dont need a session.
PS: If you have no problem with the helper functions then I can just add them along with my PR

@ArjixWasTaken
Copy link
Author

aight, i managed to write a provider for shiro.is

@ArjixWasTaken
Copy link
Author

can you, idk, change the bot that checks the quality of the code?
i follow pep standards and it always has a problem against me...

@Oshan96
Copy link
Owner

Oshan96 commented Feb 19, 2021

I'll look into it, I rarely have issues with it since I have configured my environment (I guess, if I remember right)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants