Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin filename comparisons do not handle path case insensitivity as Windows does #61

Open
Ortham opened this issue Sep 11, 2019 · 0 comments

Comments

@Ortham
Copy link
Owner

Ortham commented Sep 11, 2019

Plugin filenames are compared case-insensitively using the unicase crate. However, unicase does not implement the same case folding behaviour as Windows (not surprising, the latter's rules are a mystery).

In practice, the only variation that I've come across is that Greek 'Ρ', 'ρ' and 'ϱ' are all considered equal by unicase, but Windows only considers the first two to be equal. Unicase does give the same results for Turkish İ, ı, I and i.

There are also several places where filenames are stored in hashsets and compared case-insensitively by lowercasing them before storage, which is not necessarily the same as case folding them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant