UpdateIAmAlive for SingleMembership fixed to not create invalid subdocuments without required properties

lehoncak-intens · wassim-k · commit ec538dd1295f · 2024-03-12T12:36:06.000+11:00
diff --git a/Orleans.Providers.MongoDB/Membership/Store/Single/SingleMembershipCollection.cs b/Orleans.Providers.MongoDB/Membership/Store/Single/SingleMembershipCollection.cs
@@ -92,8 +92,11 @@ public async Task<MembershipTableData> ReadRow(string deploymentId, SiloAddress
 
         public async Task UpdateIAmAlive(string deploymentId, SiloAddress address, DateTime iAmAliveTime)
         {
-            await Collection.UpdateOneAsync(x => x.DeploymentId == deploymentId,
-                Update
+            var filter = Builders<DeploymentDocument>.Filter.And(
+                Builders<DeploymentDocument>.Filter.Eq(x => x.DeploymentId, deploymentId),
+                Builders<DeploymentDocument>.Filter.Exists($"Members.{BuildKey(address)}", true));
+
+            await Collection.UpdateOneAsync(filter, Update
                     .Set($"Members.{BuildKey(address)}.IAmAliveTime", LogFormatter.PrintDate(iAmAliveTime)));
         }
 

Original file line number	Diff line number	Diff line change
`@@ -92,8 +92,11 @@ public async Task<MembershipTableData> ReadRow(string deploymentId, SiloAddress`
`92`	`92`
`93`	`93`	`public async Task UpdateIAmAlive(string deploymentId, SiloAddress address, DateTime iAmAliveTime)`
`94`	`94`	`{`
`95`		`- await Collection.UpdateOneAsync(x => x.DeploymentId == deploymentId,`
`96`		`- Update`
	`95`	`+ var filter = Builders<DeploymentDocument>.Filter.And(`
	`96`	`+ Builders<DeploymentDocument>.Filter.Eq(x => x.DeploymentId, deploymentId),`
	`97`	`+ Builders<DeploymentDocument>.Filter.Exists($"Members.{BuildKey(address)}", true));`
	`98`	`+`
	`99`	`+ await Collection.UpdateOneAsync(filter, Update`
`97`	`100`	`.Set($"Members.{BuildKey(address)}.IAmAliveTime", LogFormatter.PrintDate(iAmAliveTime)));`
`98`	`101`	`}`
`99`	`102`