Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project: before_save hooks make things hard to test? #310

Open
ybakos opened this issue Oct 21, 2023 · 0 comments
Open

Project: before_save hooks make things hard to test? #310

ybakos opened this issue Oct 21, 2023 · 0 comments

Comments

@ybakos
Copy link
Member

ybakos commented Oct 21, 2023

See #306. If resolved, this becomes less of an issue.

Can't save a project under test because the state geometry isn't of the right type, causing the before_save hook assign_state to fail.

Add a conditional as a stopgap measure? Need to make sure that wouldn't break existing functionality.
ybakos added a commit that referenced this issue Oct 21, 2023
@ybakos
State: Rename structure_sum and use in view
dc804a5 
The state partial is using the project count instead of the number of structures.
Rename the method, get it under test, and use it.

References #307, #310, #309
ybakos added a commit that referenced this issue Oct 21, 2023
@ybakos
State: Stub method tests.
b32dd64 
These methods rely on database summing, and we need to cleanly save
projects to the db in order to test this properly.

References #307, #302, #306, #308, #310
@ybakos ybakos mentioned this issue Oct 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ybakos