Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DemoAPP] Update show code text #361

Closed
1 task done
ludovic35 opened this issue Dec 19, 2024 · 0 comments · Fixed by #362
Closed
1 task done

[DemoAPP] Update show code text #361

ludovic35 opened this issue Dec 19, 2024 · 0 comments · Fixed by #362
Assignees
@pylapp @ludovic35
Labels
🔍 triage A new issue that needs to be treated

Comments

@ludovic35
Copy link
Member

ludovic35 commented Dec 19, 2024 •
edited
Loading

Prerequisites

As a

user

... I want to

see the right text

... so that I can

sac what to do

Motivation and context

use key "app_tokens_common_viewCodeExample_label" for token
use key "app_components_common_viewCodeExample_label" for component

"app_tokens_common_viewCodeExample_label" = "View token code example";
"app_components_common_viewCodeExample_label" = "View component code example";

rename keys to
// MARK: - Common
-"app_tokens_code_visibility_button_a11y" = "Toggle code visibility";
-"app_tokens_code_copy_button_a11y" = "Copy code to clipboard";

"app_common_viewCodeExample_label_a11y" = "Toggle code visibility";
"app_common_copyCode_a11y" = "Copy code";

Proposed Solution

No response

Other

No response

Contact Details

No response
@ludovic35 ludovic35 added the 🔍 triage A new issue that needs to be treated label Dec 19, 2024
@ludovic35 ludovic35 linked a pull request Dec 19, 2024 that will close this issue
[#361] Update show code text #362
Merged
13 tasks
pylapp pushed a commit that referenced this issue Dec 20, 2024
@ludovic35
refactor: update code sample text view in demo app (#361) (#362)
327475d 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp mentioned this issue Jan 9, 2025
Merged
pylapp added a commit that referenced this issue Jan 9, 2025
@pylapp @ludovic35 @boosted-bot
Version 0.9.0 (#381)
681c874 
Release of version 0.9.0
See below the full CHANGELOG details.

Added:
- [Library] Button component tokens (tokenator *20250109124012*)
- [Library] Size semantic tokens `sizeIconWithLabelMediumSizeXs` and `sizeIconWithLabelSmallSizeXs`
- [Library] Color semantic tokens `colorOpacityLowest*`, `colorOpacityLower*`, `colorChartBorder*` and `colorChartBorderContrast*`

Changed:
- [Library] Rename color semantic tokens `colorContentOnStatusEmphasizedNeutral*` to `colorContentOnStatusEmphasizedAlt*`
- [Library] Rename color semantic tokens `colorOpacityInvisibleBlack*` to `colorOpacityTransparent*`
- [Library] Update color tokens and size tokens (tokenator *20250108083200*, tokens *v24.12.17*, tokens *v24.12.18*)
- [Library] Add details about API versions in documentation ([#374](#374))
- [DemoApp] Update show code text ([#361](#361))

Removed:
- [Library] `colorOpacityInvisibleWhite*`, `colorContentOnActionNegative*` color semantic tokens

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Ludovic Pinel <[email protected]>
Co-authored-by: boosted-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pylapp pylapp

@ludovic35 ludovic35

Labels
🔍 triage A new issue that needs to be treated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#361] Update show code text Orange-OpenSource/ouds-ios
2 participants
@pylapp @ludovic35