Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DemoApp] Update demo app colors #354

Closed
paulinea opened this issue Dec 18, 2024 · 7 comments · Fixed by #372
Closed

[DemoApp] Update demo app colors #354

paulinea opened this issue Dec 18, 2024 · 7 comments · Fixed by #372
Assignees
Labels
📱 demo app Update of the Demo App

Comments

@paulinea
Copy link
Member

paulinea commented Dec 18, 2024

New tokens have been applied to the demo app designs in Figma and some colors have been changed:

  • Cards background color in light mode (from black to light grey) and the associated content (from white to black)
  • Token category headers background (from black to light grey) and the associated content (from white to black)
  • Grid illustrations background in light mode (from black to light grey)
  • In Size token illustration

All these changes must be applied to the demo app.

@paulinea paulinea added the 📱 demo app Update of the Demo App label Dec 18, 2024
@paulinea paulinea changed the title Update demo app colors [DemoApp] Update demo app colors Dec 18, 2024
@paulinea paulinea moved this from Triage to Todo in [OUDS] Project Dec 18, 2024
@ludovic35 ludovic35 self-assigned this Dec 18, 2024
@ludovic35 ludovic35 moved this from Todo to In Progress in [OUDS] Project Dec 18, 2024
@ludovic35 ludovic35 linked a pull request Dec 20, 2024 that will close this issue
13 tasks
@pylapp
Copy link
Member

pylapp commented Jan 6, 2025

📣 New TestFlight ALPHA upload available 🚀

Please, get the new build from TestFlight app, or contact the project maintainers (@ludovic35 or @pylapp) to get access.

  • Display name: OUDS Showcase ALPHA (354)
  • Version: 0.9.0
  • Build number: 1736158838
  • Build tag: f55473c
  • Build type: ALPHA
  • Build details (GitHub): 354

cc @B3nz01d (product owner)
cc @pylapp @ludovic35 (dev team)
cc @MaximeTonnerre @mccart77 @iassab @TonyAntonyHello (design team)

This is an automated message sent with love thanks to Fastlane from our CI/CD pipeline 🤘

@pylapp
Copy link
Member

pylapp commented Jan 7, 2025

📣 New TestFlight ALPHA upload available 🚀

Please, get the new build from TestFlight app, or contact the project maintainers (@ludovic35 or @pylapp) to get access.

  • Display name: OUDS Showcase ALPHA (354)
  • Version: 0.9.0
  • Build number: 1736261986
  • Build tag: 53d9059
  • Build type: ALPHA
  • Build details (GitHub): 354

cc @B3nz01d (product owner)
cc @pylapp @ludovic35 (dev team)
cc @MaximeTonnerre @mccart77 @iassab @TonyAntonyHello (design team)

This is an automated message sent with love thanks to Fastlane from our CI/CD pipeline 🤘

@ludovic35 ludovic35 moved this from In Progress to In Review in [OUDS] Project Jan 7, 2025
@pylapp
Copy link
Member

pylapp commented Jan 8, 2025

📣 New TestFlight ALPHA upload available 🚀

Please, get the new build from TestFlight app, or contact the project maintainers (@ludovic35 or @pylapp) to get access.

  • Display name: OUDS Showcase ALPHA (354)
  • Version: 0.9.0
  • Build number: 1736333003
  • Build tag: feff346
  • Build type: ALPHA
  • Build details (GitHub): 354

cc @B3nz01d (product owner)
cc @pylapp @ludovic35 (dev team)
cc @MaximeTonnerre @mccart77 @iassab @TonyAntonyHello (design team)

This is an automated message sent with love thanks to Fastlane from our CI/CD pipeline 🤘

@ludovic35
Copy link
Member

ludovic35 commented Jan 10, 2025

Remarque From valider (Anton)
Mes commentaires sur l'application sont les suivants :

  1. Il faut vérifier les tokens pour la couleur du texte. Dans la version sombre de l'application, le texte n'est pas visible dans la description, le menu et le titre de la page.

  2. Dans la catégorie Taille, tous les objets doivent être alignés sur le bord gauche, et non centrés.

  3. Il est également nécessaire d'utiliser un système unifié dans la description. Le nom du token doit être suivi (entre parenthèses) de sa valeur avec une description (en pourcentage, pixels, etc.). Actuellement, les descriptions sont incohérentes.

  4. Dans la catégorie Espacement, il faut vérifier les tokens dans les exemples avec illustrations.

  5. Dans la catégorie Bordure, les lignes doivent être à l'intérieur de l'objet, et non à l'extérieur.

Image
Image
Image
Image
Image
Image

@ludovic35
Copy link
Member

  1. Mise a jour des token nécessaire
  2. Sera revue avec l'issue [Demo App] Update size token screen #284
  3. Sera revue avec l'issue [Demo App] Update size token screen #284
    4.oui
  4. pas possible SwftUI ne ne le permet pas

@pylapp
Copy link
Member

pylapp commented Jan 10, 2025

📣 New TestFlight ALPHA upload available 🚀

Please, get the new build from TestFlight app, or contact the project maintainers (@ludovic35 or @pylapp) to get access.

  • Display name: OUDS Showcase ALPHA (354)
  • Version: 0.10.0
  • Build number: 1736518228
  • Build tag: ac059f1
  • Build type: ALPHA
  • Build details (GitHub): 354

cc @B3nz01d (product owner)
cc @pylapp @ludovic35 (dev team)
cc @MaximeTonnerre @mccart77 @iassab @TonyAntonyHello (design team)

This is an automated message sent with love thanks to Fastlane from our CI/CD pipeline 🤘

@B3nz01d
Copy link
Collaborator

B3nz01d commented Jan 15, 2025

@TonyAntonyHello have you bee able to chexk this version?
cc @MaximeTonnerre

pylapp pushed a commit that referenced this issue Jan 15, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in [OUDS] Project Jan 15, 2025
pylapp pushed a commit that referenced this issue Jan 15, 2025
Tested-by: Anton Astafev <[email protected]>
Tested-by: Benoit Suzanne <[email protected]>
Reviewed-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📱 demo app Update of the Demo App
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants