From 6d694b93938ed79c747025a91a6444737b9d109f Mon Sep 17 00:00:00 2001 From: Pierre-Yves Lapersonne Date: Wed, 10 Jul 2024 14:50:03 +0200 Subject: [PATCH] chore: add pull request template (#25, #24) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Note this template is based on the great work found at Orange-OpenSource/Orange-Boosted-Bootstrap Closes #25 Closes #24 Co-authored-by: Julien Déramond Co-authored-by: Pierre-Yves Lapersonne Signed-off-by: Pierre-Yves Lapersonne --- .github/pull_request_template.md | 66 ++++++++++++++++++++++++++++++++ 1 file changed, 66 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000000..b7b380cf3d --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,66 @@ +_Note: Please transform `- [ ]` into `- (NA)` in the description when things are not applicable_ + +### Related issues + + + +### Description + + + +### Motivation & Context + + + +### Types of change + + + + +- Bug fix (non-breaking which fixes an issue) +- New feature (non-breaking change which adds functionality) +- Refactoring (non-breaking change) +- Breaking change (fix or feature that would change existing functionality) + +### Previews + + + +### Checklist + + + + + + +#### Contribution + +- [ ] I have read the [contributing guidelines](https://github.com/Orange-OpenSource/ouds-ios/blob/develop/.github/CONTRIBUTING.md) + +#### Accessibility + +- [ ] My change follows accessibility good practices + +#### Design + +- [ ] My change respects the design guidelines of _Orange Unified Design System_ + +#### Development + +- [ ] My change follows the [developer guide](https://github.com/Orange-OpenSource/ouds-ios/blob/develop/.github/DEVELOP.md) +- [ ] I have added unit tests to cover my changes _(optional)_ + +#### Documentation + +- [ ] My change introduces changes to the documentation and/or I have updated the documentation accordingly + +### Checklist (for Core Team only) + +- [ ] The evolution have been tested and the project builds for iPhones and iPads +- [ ] Code review has been done by reviewers according to [CODEOWNERS file](https://github.com/Orange-OpenSource/ouds-ios/blob/develop/.github/CODEOWNERS) +- [ ] Design review has been done +- [ ] Accessibiltiy review has been done +- [ ] Q/A team has tested the evolution +- [ ] Documentation has been updated if relevant +- [ ] Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE) +- [ ] CHANGELOG has been updated respecting [keep a changelog rules](https://keepachangelog.com/en/1.0.0/) and reference the issues