New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that deposit and withdraw to/from strategy occurred in vault #299

Open

dhruvinparikh opened this issue Feb 2, 2022 · 0 comments

Labels

Collaborator

dhruvinparikh commented Feb 2, 2022 •

edited

Loading

Problem

Whenever Vault deposit to the strategy through series of function call using MultiCall contract, it does not consider return values if any protocol returns on deposit.
Whenever Vault withdraws from the strategy through series of function call using MultiCall contract, it does not consider return values if any protocol returns during withdraw.

Possible Solution

Deposit : Check the difference of vault balance in underlying token before and after deposit. Some protocols may limit the investment so consider that via calls made to the adapter.Revert if the difference is not as expected
Withdraw : Check the difference of vault balance in underlying token before and after withdraw. Revert if the difference is not as expected.

The text was updated successfully, but these errors were encountered:

dhruvinparikh added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment