Skip to content

Commit acc6862

Browse files
committed
OTR(Frontend): Move to new ComboBox implementation [deploy]
1 parent 9754bfa commit acc6862

File tree

4 files changed

+30
-38
lines changed

4 files changed

+30
-38
lines changed

frontend/packages/otr/src/components/clerkInterpreter/filters/ClerkInterpreterAutocompleteFilters.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { useEffect, useState } from 'react';
22
import {
3-
AutocompleteValue,
43
ComboBox,
54
CustomTextField,
65
H3,
@@ -66,9 +65,9 @@ export const ClerkInterpreterAutocompleteFilters = ({
6665

6766
const handleFilterChange =
6867
(filter: keyof Omit<ClerkInterpreterFilters, 'fromLang' | 'toLang'>) =>
69-
({}, value: AutocompleteValue) => {
68+
(value?: string) => {
7069
setPage(0);
71-
dispatch(addClerkInterpreterFilter({ [filter]: value?.value }));
70+
dispatch(addClerkInterpreterFilter({ [filter]: value }));
7271
};
7372
const handleLanguageFilterChange =
7473
(filter: 'fromLang' | 'toLang') => (language?: string) => {

frontend/packages/otr/src/components/clerkInterpreter/qualification/QualificationFields.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import dayjs, { Dayjs } from 'dayjs';
22
import { ChangeEvent, useEffect, useState } from 'react';
33
import {
4-
AutocompleteValue,
54
ComboBox,
65
CustomButton,
76
CustomSwitch,
@@ -86,8 +85,8 @@ export const QualificationFields = ({
8685
setIsQualificationDataChanged(true);
8786
};
8887

89-
const handleExaminationTypeChange = ({}, value: AutocompleteValue) => {
90-
const examinationType = value?.value as ExaminationType;
88+
const handleExaminationTypeChange = (value?: string) => {
89+
const examinationType = value as ExaminationType;
9190

9291
setQualification({
9392
...qualification,
@@ -96,9 +95,9 @@ export const QualificationFields = ({
9695
setIsQualificationDataChanged(true);
9796
};
9897

99-
const handleBeginDateChange = ({}, value: AutocompleteValue) => {
98+
const handleBeginDateChange = (value?: string) => {
10099
const PERIOD_OF_VALIDITY = 5;
101-
const beginDate = value ? dayjs(value?.value) : undefined;
100+
const beginDate = value ? dayjs(value) : undefined;
102101
const endDate = beginDate?.add(PERIOD_OF_VALIDITY, 'year');
103102

104103
setQualification({

frontend/packages/otr/src/components/publicInterpreter/filters/PublicInterpreterFilters.tsx

Lines changed: 23 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import {
1010
useState,
1111
} from 'react';
1212
import {
13-
AutocompleteValue,
1413
ComboBox,
1514
CustomButton,
1615
H3,
@@ -71,7 +70,7 @@ export const PublicInterpreterFilters = ({
7170
fromLang: '',
7271
toLang: '',
7372
name: '',
74-
region: null,
73+
region: '',
7574
};
7675

7776
// State
@@ -133,30 +132,17 @@ export const PublicInterpreterFilters = ({
133132
setSearchButtonDisabled(false);
134133
};
135134

136-
const handleComboboxFilterChange =
137-
(filterName: SearchFilter) =>
138-
(
139-
{},
140-
value: AutocompleteValue,
141-
reason:
142-
| 'selectOption'
143-
| 'createOption'
144-
| 'removeOption'
145-
| 'blur'
146-
| 'clear'
147-
) => {
148-
if (reason === 'clear') {
149-
setFilters((prevState) => ({ ...prevState, [filterName]: '' }));
150-
setValues((prevState) => ({ ...prevState, [filterName]: null }));
151-
} else {
152-
setFilters((prevState) => ({
153-
...prevState,
154-
[filterName]: value?.value || '',
155-
}));
156-
setValues((prevState) => ({ ...prevState, [filterName]: value }));
157-
}
158-
setSearchButtonDisabled(false);
159-
};
135+
const handleRegionChange = (region?: string) => {
136+
setFilters((prevState) => ({
137+
...prevState,
138+
[SearchFilter.Region]: region || '',
139+
}));
140+
setValues((prevState) => ({
141+
...prevState,
142+
[SearchFilter.Region]: region || '',
143+
}));
144+
setSearchButtonDisabled(false);
145+
};
160146

161147
const handleLanguageChange =
162148
(languageField: SearchFilter.FromLang | SearchFilter.ToLang) =>
@@ -285,8 +271,17 @@ export const PublicInterpreterFilters = ({
285271
<ComboBox
286272
data-testid="public-interpreter-filters__region-combobox"
287273
{...getComboBoxAttributes(SearchFilter.Region)}
288-
value={values[SearchFilter.Region]}
289-
onChange={handleComboboxFilterChange(SearchFilter.Region)}
274+
value={
275+
values[SearchFilter.Region]
276+
? {
277+
label: RegionUtils.translateRegion(
278+
values[SearchFilter.Region]
279+
),
280+
value: values[SearchFilter.Region],
281+
}
282+
: null
283+
}
284+
onChange={handleRegionChange}
290285
placeholder={t('region.placeholder')}
291286
label={t('region.placeholder')}
292287
id="filters-region"

frontend/packages/otr/src/interfaces/publicInterpreter.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { AutocompleteValue } from 'shared/components';
21
import { WithId } from 'shared/interfaces';
32

43
import { LanguagePair } from 'interfaces/languagePair';
@@ -24,5 +23,5 @@ export interface PublicInterpreterFilterValues {
2423
fromLang: string;
2524
toLang: string;
2625
name: string;
27-
region: AutocompleteValue;
26+
region: string;
2827
}

0 commit comments

Comments
 (0)