Skip to content

Commit 26b3112

Browse files
committed
OY-4836 Backtrack hours instead of days, tweaks to YtlFetchActor
1 parent 1e67fc5 commit 26b3112

File tree

3 files changed

+9
-13
lines changed

3 files changed

+9
-13
lines changed

src/main/resources/oph-configuration/suoritusrekisteri.properties.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ suoritusrekisteri.koski.update.cronJob={{ suoritusrekisteri_koski_update_cronjob
126126
suoritusrekisteri.koski.update.kkHaut={{ suoritusrekisteri_koski_update_kkHaut | default('false') }}
127127
suoritusrekisteri.koski.update.toisenAsteenHaut={{ suoritusrekisteri_koski_update_toisenAsteenHaut | default('false') }}
128128
suoritusrekisteri.koski.update.jatkuvatHaut={{ suoritusrekisteri_koski_update_jatkuvatHaut | default('false') }}
129-
suoritusrekisteri.modifiedhakemukset.backtrack.days={{ suoritusrekisteri_modifiedhakemukset_backtrack_days | default('2')}}
129+
suoritusrekisteri.modifiedhakemukset.backtrack.hours={{ suoritusrekisteri_modifiedhakemukset_backtrack_hours | default('2')}}
130130
suoritusrekisteri.oppijanumerorekisteri-service.max-connections={{ suoritusrekisteri_oppijanumerorekisteriservice_max_connections | default('50')}}
131131
suoritusrekisteri.oppijanumerorekisteri-service.max-connection-queue-ms={{ suoritusrekisteri_oppijanumerorekisteriservice_max_connection_queue_ms | default('60000')}}
132132
suoritusrekisteri.oppijanumerorekisteri-service.max.oppijat.batch.size={{ suoritusrekisteri_oppijanumerorekisteriservice_max_oppijat_batch_size | default('5000')}}

src/main/scala/fi/vm/sade/hakurekisteri/integration/ytl/YtlFetchActor.scala

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,11 @@
11
package fi.vm.sade.hakurekisteri.integration.ytl
22

3-
import akka.actor.{Actor, ActorLogging, ActorRef}
3+
import akka.actor.{Actor, ActorLogging, ActorRef, ActorSystem}
44
import akka.pattern.pipe
55
import fi.vm.sade.hakurekisteri.Config
66
import fi.vm.sade.hakurekisteri.integration.ExecutorUtil
77
import fi.vm.sade.hakurekisteri.integration.hakemus.{HetuPersonOid, IHakemusService}
8-
import fi.vm.sade.hakurekisteri.integration.henkilo.{
9-
Henkilo,
10-
IOppijaNumeroRekisteri,
11-
PersonOidsWithAliases
12-
}
8+
import fi.vm.sade.hakurekisteri.integration.henkilo.{Henkilo, IOppijaNumeroRekisteri, PersonOidsWithAliases}
139
import fi.vm.sade.properties.OphProperties
1410
import org.apache.commons.io.IOUtils
1511
import scalaz.concurrent.Task
@@ -52,7 +48,7 @@ class YtlFetchActor(
5248
val minIntervalBetween = 1000 * 60 * 60 * 22 //At least 22 hours between nightly syncs
5349

5450
implicit val ec: ExecutionContext = ExecutorUtil.createExecutor(
55-
config.integrations.asyncOperationThreadPoolSize,
51+
20,
5652
getClass.getSimpleName
5753
)
5854

@@ -99,7 +95,7 @@ class YtlFetchActor(
9995
log.error(t, s"($tunniste) Manual sync for haku ${s.hakuOid} failed...")
10096
}
10197
log.info(s"Ytl-sync käynnistetty haulle ${s.hakuOid} tunnisteella $tunniste")
102-
resultF pipeTo sender
98+
sender ! tunniste
10399
case s: YtlSyncSingle =>
104100
if (s.needsToBeActiveKkHakuOid.forall(oid => activeKKHakuOids.get().contains(oid))) {
105101
val tunniste = s.tunniste
@@ -110,7 +106,7 @@ class YtlFetchActor(
110106
case Failure(t) =>
111107
log.error(t, s"($tunniste) Manual sync for person ${s.personOid} failed...")
112108
}
113-
log.info(s"Ytl-sync käynnistetty haulle ${s.personOid} tunnisteella $tunniste")
109+
log.info(s"Ytl-sync käynnistetty oidille ${s.personOid} tunnisteella $tunniste")
114110
resultF pipeTo sender
115111
} else {
116112
val infoStr = s"Not ytl-syncing $s because the haku is not an active kk-haku"

src/main/scala/support/Integrations.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -550,11 +550,11 @@ class BaseIntegrations(rekisterit: Registers, system: ActorSystem, config: Confi
550550
hakemusService.addTrigger(arvosanaTrigger)
551551
hakemusService.addTrigger(ytlTrigger)
552552

553-
val daysToBacktrack: Int =
554-
OphUrlProperties.getProperty("suoritusrekisteri.modifiedhakemukset.backtrack.days").toInt
553+
val hoursToBacktrack: Int =
554+
OphUrlProperties.getProperty("suoritusrekisteri.modifiedhakemukset.backtrack.hours").toInt
555555
implicit val scheduler = system.scheduler
556556
hakemusService.processModifiedHakemukset(modifiedAfter =
557-
new Date(Platform.currentTime - TimeUnit.DAYS.toMillis(daysToBacktrack))
557+
new Date(Platform.currentTime - TimeUnit.HOURS.toMillis(hoursToBacktrack))
558558
)
559559

560560
val quartzScheduler = StdSchedulerFactory.getDefaultScheduler()

0 commit comments

Comments
 (0)