OY-4784 Slightly improve error reporting. Still a bit iffy.

msiukola · msiukola · commit 1ef2dda630a8 · 2024-04-11T17:15:44.000+03:00
diff --git a/src/main/scala/fi/vm/sade/hakurekisteri/integration/ytl/YtlFetchActor.scala b/src/main/scala/fi/vm/sade/hakurekisteri/integration/ytl/YtlFetchActor.scala
@@ -338,7 +338,6 @@ class YtlFetchActor(
                 }
 
               Future.sequence(futures.toSeq).onComplete { _ =>
-                log.info(s"($tunniste) Futures complete! Haku $hakuOid")
                 log
                   .info(
                     s"($tunniste) Completed YTL syncAll for haku $hakuOid with hasErrors=${hasErrors.get()}"
@@ -347,7 +346,11 @@ class YtlFetchActor(
             }
             result.map(r => {
               log.info(s"($tunniste) $r Future finished, returning none")
-              None
+              if (hasErrors.get()) {
+                Some(new Throwable(s"($tunniste) sync for haku $hakuOid had errors"))
+              } else {
+                None
+              }
             })
           }
         })

Original file line number	Diff line number	Diff line change
`@@ -338,7 +338,6 @@ class YtlFetchActor(`
`338`	`338`	`}`
`339`	`339`
`340`	`340`	`Future.sequence(futures.toSeq).onComplete { _ =>`
`341`		`- log.info(s"($tunniste) Futures complete! Haku $hakuOid")`
`342`	`341`	`log`
`343`	`342`	`.info(`
`344`	`343`	`s"($tunniste) Completed YTL syncAll for haku $hakuOid with hasErrors=${hasErrors.get()}"`
`@@ -347,7 +346,11 @@ class YtlFetchActor(`
`347`	`346`	`}`
`348`	`347`	`result.map(r => {`
`349`	`348`	`log.info(s"($tunniste) $r Future finished, returning none")`
`350`		`- None`
	`349`	`+ if (hasErrors.get()) {`
	`350`	`+ Some(new Throwable(s"($tunniste) sync for haku $hakuOid had errors"))`
	`351`	`+ } else {`
	`352`	`+ None`
	`353`	`+ }`
`351`	`354`	`})`
`352`	`355`	`}`
`353`	`356`	`})`