Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnrichOrganisaatioOid will cause typescript any #209

Open
J-Kallunki opened this issue Apr 22, 2020 · 0 comments
Open

EnrichOrganisaatioOid will cause typescript any #209

J-Kallunki opened this issue Apr 22, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@J-Kallunki
Copy link
Contributor

EnrichOrganisaatioOid will cause many object to accept any keys that never exist.

https://github.com/Opetushallitus/ehoks-ui/blob/ffca5eeb311f322948a89b569a2364a3cad5a4a1/shared/models/EnrichOrganisaatioOid.ts#L12,L17

Add generic of all possible keys to
export const EnrichOrganisaatioOid = (fieldPostfix: string) =>

And replace DynamicObject with it at
.volatile((): DynamicObject => ({}))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@J-Kallunki