OK-784 throw an exception when payment status updater returns zero payment states

Author: vaeinoe

spec/ataru/kk_application_payment/kk_application_payment_status_updater_job_spec.clj

@@ -9,8 +9,8 @@
             [clj-time.format :as time-format]
             [clojure.java.jdbc :as jdbc]
             [clojure.string :as str]
-            [speclj.core :refer [it describe should-not-throw stub should-have-invoked should-not-have-invoked
-                                 tags with-stubs should= around before]]
+            [speclj.core :refer [it describe should-throw should-not-throw stub should-have-invoked
+                                 should-not-have-invoked tags with-stubs should= around before]]
             [ataru.kk-application-payment.kk-application-payment :as payment]
             [ataru.fixtures.application :as application-fixtures]
             [ataru.fixtures.form :as form-fixtures]
@@ -65,6 +65,13 @@
                            (get-many-from [_ _])
                            (remove-from [_ _])
                            (clear-all [_])))
+(def empty-get-haut-cache (reify cache-service/Cache
+                           (get-from [_ _]
+                             [])
+                           (get-many-from [_ _])
+                           (remove-from [_ _])
+                           (clear-all [_])))
+
 
 (defn start-runner-job [_ _ _ _])
 
@@ -82,6 +89,13 @@
                        :koodisto-cache   fake-koodisto-cache
                        :maksut-service   mock-maksut-service}))
 
+(def runner-with-empty-haku-cache
+  (map->FakeJobRunner {:tarjonta-service fake-tarjonta-service
+                       :person-service   fake-person-service
+                       :get-haut-cache   empty-get-haut-cache
+                       :koodisto-cache   fake-koodisto-cache
+                       :maksut-service   mock-maksut-service}))
+
 (declare conn)
 (declare spec)
 
@@ -142,6 +156,19 @@
                    :maksut-secret test-maksut-secret}
                   (select-keys payment [:application-key :state :maksut-secret]))))
 
+          (it "should throw an exception when person and term found but updater doesn't find eligible applications"
+              (let [application-id (unit-test-db/init-db-fixture
+                                     form-fixtures/payment-exemption-test-form
+                                     application-fixtures/application-without-hakemusmaksu-exemption
+                                     nil)]
+                ; Here the handler first resolves the person from application correctly, but then the updater
+                ; function itself queries for all applications with hakus from get-haku-cache (= all haku oids from applications)
+                ; and finds none from an empty one. This may happen with the very first application(s) for haku until
+                ; cache is completely refreshed, so the job runner needs to retry.
+                (should-throw
+                  (updater-job/update-kk-payment-status-for-person-handler
+                    {:application_id application-id} runner-with-empty-haku-cache))))
+
           (it "should update payment status fetching person and term with application key"
               (let [application-id (unit-test-db/init-db-fixture
                                      form-fixtures/payment-exemption-test-form

src/clj/ataru/kk_application_payment/kk_application_payment_status_updater_job.clj

@@ -145,24 +145,33 @@
               (payment/update-payments-for-person-term-and-year person-service tarjonta-service
                                                                 koodisto-cache get-haut-cache
                                                                 person-oid application-term application-year)]
-          (log/info "Update kk application payment status handler for"
-                    person-oid application-term application-year
-                    "returned" (count existing-payments) "created or modified payments and"
-                    (count modified-payments) "existing payments before creating / modifying.")
-          (doseq [payment modified-payments]
-            (let [new-state (:state payment)]
-              (cond
-                (= (:awaiting payment/all-states) new-state)
-                (create-payment-and-send-email job-runner maksut-service payment))))
-
-          (doseq [application-payment existing-payments]
-            (let [{:keys [application payment]} application-payment]
-              (cond
-                (needs-reminder-sent? payment)
-                (send-reminder-email-and-mark-sent job-runner payment application))))
-
-          (invalidate-maksut-payments-if-needed maksut-service modified-payments)
-          (log/info "Update kk payment status handler for" person-oid application-term application-year "finished."))
+          (if (or (some? modified-payments) (some? existing-payments))
+            (do
+              (log/info "Update kk application payment status handler for"
+                        person-oid application-term application-year
+                        "returned" (count existing-payments) "created or modified payments and"
+                        (count modified-payments) "existing payments before creating / modifying.")
+              (doseq [payment modified-payments]
+                (let [new-state (:state payment)]
+                  (cond
+                    (= (:awaiting payment/all-states) new-state)
+                    (create-payment-and-send-email job-runner maksut-service payment))))
+
+              (doseq [application-payment existing-payments]
+                (let [{:keys [application payment]} application-payment]
+                  (cond
+                    (needs-reminder-sent? payment)
+                    (send-reminder-email-and-mark-sent job-runner payment application))))
+
+              (invalidate-maksut-payments-if-needed maksut-service modified-payments)
+              (log/info "Update kk payment status handler for" person-oid application-term application-year "finished."))
+
+            ; Here we've already established there should be a person with at least one application, but for the first
+            ; applications in haku, get-haku-cache may still be refreshing so it doesn't return any applications for
+            ; the specific haku. That's a temporary error, and quite short-lived, so let's try again later.
+            (throw (ex-info "Could not find or create a payment status for person" {:person-oid person-oid
+                                                                                    :term application-term
+                                                                                    :year application-year}))))
         (log/warn "Update kk payment status handler not run for params"
                   person_oid term year application_id application_key
                   "because no valid payment info was found.")))))