Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove session reminder sms code from errgroup #60

Open
harveysanders opened this issue Feb 6, 2023 · 0 comments
Open

Remove session reminder sms code from errgroup #60

harveysanders opened this issue Feb 6, 2023 · 0 comments

Comments

@harveysanders
Copy link
Contributor

https://github.com/OperationSpark/service-signups/blob/main/notify/info_session.go#L245-L277
ErrGroup will cancel all the contexts if any fail. For the notifications, we actually do not want to cancel the rest of the outgoing messages if any one message fails. They should fail independently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@harveysanders