fix(motion-control): Don't clear stepper-ok in stop request (#813) #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We don't need to clear the stepper ok field when we get a stop message. * Ok i was wrong about how this worked. We don't want to leave the motor enable false we just want to turn the brake on for a bit then turn it back off to leave the motor enabled.
vegano1
reviewed
Nov 5, 2024
| @@ -189,7 +189,8 @@ class MotionController { | |||
| if (hardware.is_timer_interrupt_running()) { | |||
| hardware.request_cancel(); | |||
| } | |||
| disable_motor(); | |||
| hardware.deactivate_motor(); | |||
There was a problem hiding this comment.
no, this is about setting logical state. also it's already been tested and merged into main, this is a cherry-pick basically
vegano1
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to clear the stepper ok field when we get a stop message.
Ok i was wrong about how this worked. We don't want to leave the motor enable false we just want to turn the brake on for a bit then turn it back off to leave the motor enabled.