fix(protocol-designer): fix layout for ProtocolSteps #16959
Merged
+30
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the layout for protocol steps, acocunting for TimelineAlerts. To maintain position without flickering when hovering timeline steps, we align the center content to the top of the container, and provide top padding dependent on the presence of timeline alerts. We also fix logic to not show timeline alerts if a stepform toolbox is open. Lastly, we make the container scrollable to handle timeline alerts and step summaries rendering at the same time, and set the timeline, stepform, and substeps toolbox heights to fill the view height with padding.
koji
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the layout for protocol steps, acocunting for TimelineAlerts. To maintain position
without flickering when hovering timeline steps, we align the center content to the top of the
container, and provide top padding dependent on the presence of timeline alerts. We also fix logic
to not show timeline alerts if a stepform toolbox is open. Lastly, we make the container scrollable
to handle timeline alerts and step summaries rendering at the same time, and set the timeline,
stepform, and substeps toolbox heights to fill the view height with padding.
closes RQA-3678
Screen.Recording.2024-11-22.at.3.00.08.PM.mov
Test Plan and Hands on Testing
Changelog
Review requests
see test plan
Risk assessment
low