feat(protocol-designer): onboarding animations for ot-2 #16958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
commented
Nov 22, 2024
| @@ -37,6 +40,21 @@ interface WizardBodyProps { | |||
| tooltipOnDisabled?: string | |||
| } | |||
|
|
|||
| const OT2_GIFS: Record<number, string> = { | |||
There was a problem hiding this comment.
Note: post-release we will revisit optimizing the animations for ot-2 and flex. Right now its a bit weird that the flex animations are in webm format but ot-2 animations are in gif format. but it seems to work okay for the release so i think its fine that they have different formats.
ncdiehl11
approved these changes
Nov 22, 2024
protocol-designer/src/pages/CreateNewProtocolWizard/WizardBody.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Nov 22, 2024
| controls={false} | ||
| aria-label={`onboarding animation for page ${stepNumber}`} | ||
| > | ||
| <source src={asset ?? ''} type="video/mp4" /> |
There was a problem hiding this comment.
why mp4? I thought the type was webm.
converted from webm to mp4?
There was a problem hiding this comment.
oops they're definitely webm, i'll fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-3677
Overview
add onboarding animations for ot-2
Test Plan and Hands on Testing
Test that the ot-2 and flex onboarding flows work with the animations
Changelog
Risk assessment
low