Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Plate reader DQA #16946

Merged
merged 4 commits into from
Nov 22, 2024
Merged

fix(app): Plate reader DQA #16946

merged 4 commits into from
Nov 22, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Nov 21, 2024

fix RQA-3570, RQA-3572, RQA-3573, RQA-3633, RQA-3634

Overview

DQA for plate reader including some LPC items

Test Plan and Hands on Testing

Screen Shot 2024-11-21 at 2 44 59 PM Screen Shot 2024-11-21 at 2 44 01 PM Screen Shot 2024-11-21 at 2 44 21 PM Screen Shot 2024-11-19 at 4 54 44 PM

Changelog

  1. In the will you need section of LPC, make instructional text full width instead of 70% width
  2. Change LPC headers to use slot only location detail level to ensure module and adapter names don't make the header too long
  3. Capitalize open and closed plate reader lid status
  4. Add plate reader output file count to protocol file count in historical protocol run

Review requests

Risk assessment

Low

@smb2268 smb2268 requested a review from mjhuff November 22, 2024 17:14
@smb2268 smb2268 marked this pull request as ready for review November 22, 2024 17:14
@smb2268 smb2268 requested a review from a team as a code owner November 22, 2024 17:14
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@smb2268 smb2268 merged commit 6ae2f38 into chore_release-8.2.0 Nov 22, 2024
45 of 52 checks passed
@smb2268 smb2268 deleted the app_plate-reader-dqa branch November 22, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants