Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): fix EmptySelectorButton style #16932

Merged
merged 3 commits into from
Nov 21, 2024
Merged

fix(components): fix EmptySelectorButton style #16932

merged 3 commits into from
Nov 21, 2024

Conversation

ncdiehl11
Copy link
Collaborator

Overview

Add hover state and fix border radius for EmptySelectorButton component

Closes RQA-3659

Test Plan and Hands on Testing

  • navigate to create protocol wizard and move through to add pipettes step
  • verify enabled hover state for "Add pipette" button produces blue35 bg color with pointer cursor
  • continue through to add modules step
  • add mag block and max out quantity to disable other module buttons
  • hover and verify disabled state is correct and default cursor

Changelog

  • fix EmptySelectorButton style

Review requests

  • see test plan

Risk assessment

kow

@ncdiehl11
fix(components): fix EmptySelectorButton style
fd9366f 
Add hover state and fix border radius for EmptySelectorButton component

Closes
@ncdiehl11 ncdiehl11 self-assigned this Nov 21, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review November 21, 2024 19:03
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner November 21, 2024 19:03
jerader
jerader approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ncdiehl11 ncdiehl11 merged commit 54dda40 into edge Nov 21, 2024
58 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_components-emptyselectorbutton branch November 21, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerader jerader jerader approved these changes

@koji koji Awaiting requested review from koji

Assignees

@ncdiehl11 ncdiehl11

Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncdiehl11 @jerader