Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abr-testing): unify all script compatibility with same ip file #16922

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

AnthonyNASC20
Copy link
Contributor

Overview

Ensures data collection scripts can all use the same IPs.json file when connecting to robots

@AnthonyNASC20 AnthonyNASC20 requested a review from a team as a code owner November 20, 2024 22:04
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rclarke0 rclarke0 changed the title Abr setup fix fix(abr-testing): unify all script compatibility with same ip file Nov 21, 2024
Copy link
Contributor

@rclarke0 rclarke0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved.

@rclarke0 rclarke0 merged commit da74897 into edge Nov 21, 2024
7 checks passed
@rclarke0 rclarke0 deleted the abr_setup_fix branch November 21, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants