Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): disable pressure sensor capabilities for PEEK pipettes #16921

Merged

Conversation

caila-marashaj
Copy link
Contributor

@caila-marashaj caila-marashaj commented Nov 20, 2024

Overview

We want to disable all pressure sensor functionality for the peek pipettes. This should consist of:

  • disabling overpressure monitoring
  • disabling liquid presence detection

@caila-marashaj caila-marashaj force-pushed the EXEC-856-disable-pressure-sensor-for-peek-pipettes branch from 7b39cf6 to 1ec9566 Compare November 20, 2024 23:17
@caila-marashaj caila-marashaj marked this pull request as ready for review November 20, 2024 23:18
@caila-marashaj caila-marashaj requested a review from a team as a code owner November 20, 2024 23:18
@ryanthecoder
Copy link
Contributor

ryanthecoder commented Nov 21, 2024

Can we also raise an error in protocol_context.py if they try to initialize a em pipette with liquid_present_detection=true and in instrument_context.py if they try to call the explicit probe or enable that property

Also in the lower level engine "command" in case they try to run it with PD so it fails during analysis instead of execution.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ryanthecoder ryanthecoder force-pushed the EXEC-856-disable-pressure-sensor-for-peek-pipettes branch from feaed8d to 9edf81c Compare November 22, 2024 14:09
@caila-marashaj caila-marashaj merged commit 02a57a1 into edge Nov 22, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants