-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(protocol-designer): fix labware tools filtering and expand/collapse behavior #16889
Conversation
…se behavior This PR addresses several functional issues with our LabwareTools component, produced when adding labware to the starting deck state. Here, I add filtering to populated expanded categories, allow independent expand/collapse toggling for multiple categories simultaneously, and auto expand/collapse all categories based on the state of the current search term. Closes RQA-3590
protocol-designer/src/pages/Designer/DeckSetup/LabwareTools.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/DeckSetup/LabwareTools.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/DeckSetup/LabwareTools.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/DeckSetup/LabwareTools.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sandbox worked as expected
…dles resetting categories and search bar
| Also, I notice a ton of rerenders after mounting— I will address in a followup @ncdiehl11 by rerendering, do you mean deck setup tools rerenders a bunch of times when you zoom into a slot? if so, that's a known issue: https://opentrons.atlassian.net/browse/AUTH-769 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me. might be worth in a followup when we refactor/clean up these components to add setSeachTerm/searchTerm and areCategoriesExpanded/setAreCategoriesExpanded to redux. Thanks for fixing this!
yes. I think it may be introduced in this component. We can get to it soon |
Overview
This PR addresses several functional issues with our LabwareTools component, produced when adding labware to the starting deck state. Here, I add filtering to populated expanded categories, allow independent expand/collapse toggling for multiple categories simultaneously, and auto expand/collapse all categories based on the state of the current search term.
NOTE: This component is pretty bloated as is, and I think we can address condensing filtering logic and improving performance in a followup. Also, I notice a ton of rerenders after mounting— I will address in a followup.
Closes RQA-3590
Closes RQA-3339
Screen.Recording.2024-11-19.at.12.16.52.PM.mov
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
medium