Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): add 10s delay after updating the plate reader to give time to boot-up. #16882

Merged

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Nov 19, 2024

Overview

The new plate reader firmware takes longer for the device to boot up after an update, even after the update_firmware command returns. When we get the device information with self._driver.get_device_info(), it can sometimes lead to an error because the device has not finished booting up. Although the update goes through, it leaves the system in a bad state, so, let's add a 10-second delay after the update_firmware returns so we can account for this issue.

Test Plan and Hands on Testing

  • Make sure we can update PVT plate readers from 7 -> 8 10 times in a row

Changelog

  • add 10s delay after updating the plate reader to give time for the device to boot up

Review requests

Risk assessment

low, unreleased

@vegano1 vegano1 requested a review from a team as a code owner November 19, 2024 15:10
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (chore_release-8.2.0@29e03ae). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##             chore_release-8.2.0   #16882   +/-   ##
======================================================
  Coverage                       ?   92.43%           
======================================================
  Files                          ?       77           
  Lines                          ?     1283           
  Branches                       ?        0           
======================================================
  Hits                           ?     1186           
  Misses                         ?       97           
  Partials                       ?        0           
Flag Coverage Δ
g-code-testing 92.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yucky

@vegano1 vegano1 changed the title fix(api): add 10s delay after updating the plate reader to give time to re-initialize. fix(api): add 10s delay after updating the plate reader to give time to boot-up. Nov 19, 2024
@vegano1 vegano1 merged commit abaade6 into chore_release-8.2.0 Nov 19, 2024
28 checks passed
@vegano1 vegano1 deleted the RQA-3580-add-plate-reader-post-update-delay branch November 19, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants