Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(abr-testing): added error handling for run log parsing #16867

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix(abr-testing): added error handling for run log parsing #16867

merged 2 commits into from
Nov 18, 2024

Conversation

rclarke0
Copy link
Contributor

@rclarke0 rclarke0 commented Nov 18, 2024 •
edited
Loading

Overview

Added error handling to run log parsing when run logs are empty due to failed protocol analysis

Test Plan and Hands on Testing

tested both scripts for 3 days using make abr-setup command.

Changelog

  • get_run_logs.py added error handling for key error
  • abr_google_drive.py added error handling for json parsing

Review requests

Risk assessment

@rclarke0 rclarke0 requested a review from a team as a code owner November 18, 2024 16:59
AnthonyNASC20
AnthonyNASC20 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@AnthonyNASC20 AnthonyNASC20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rclarke0 rclarke0 merged commit 1e6df83 into edge Nov 18, 2024
5 checks passed
@rclarke0 rclarke0 deleted the abr-run-log-fixes branch November 18, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyNASC20 AnthonyNASC20 AnthonyNASC20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rclarke0 @AnthonyNASC20