feat (abr-testing): simulate protocols with csv parameter #16685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rclarke0
reviewed
Nov 5, 2024
| protocol_end = datetime.strptime( | ||
| file_results.get("completedAt", ""), "%Y-%m-%dT%H:%M:%S.%f%z" | ||
| ) | ||
| commands = file_results.get("commands") |
There was a problem hiding this comment.
commands is already defined on line 292 of this function. remove line 345 and use variable commandData
rclarke0
reviewed
Nov 5, 2024
| protocol_end = datetime.strptime( | ||
| file_results.get("completedAt", ""), "%Y-%m-%dT%H:%M:%S.%f%z" | ||
| ) | ||
| commands = file_results.get("commands") |
There was a problem hiding this comment.
remove line 393 since commands is defined as commandData on line 370
rclarke0
reviewed
Nov 5, 2024
| protocol_end = datetime.strptime( | ||
| file_results.get("completedAt", ""), "%Y-%m-%dT%H:%M:%S.%f%z" | ||
| ) | ||
| commands = file_results.get("commands") |
There was a problem hiding this comment.
remove line 477 since commands is defined as commandData on line 410
rclarke0
reviewed
Nov 5, 2024
| @@ -241,6 +241,7 @@ def parse_results_volume( | |||
| "Right Pipette Total Aspirates", | |||
| "Right Pipette Total Dispenses", | |||
| "Gripper Pick Ups", | |||
| "Gripper Pick Ups of None", | |||
There was a problem hiding this comment.
this is supposed to be Gripper Pick Ups of opentrons_tough_pcr_auto_sealing_lid
sfoster1
approved these changes
Nov 5, 2024
rclarke0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Enabled support for simulating protocols with csv parameters