Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(abt): fix Makefile variable #16525

Merged
merged 1 commit into from
Oct 17, 2024
Merged

test(abt): fix Makefile variable #16525

merged 1 commit into from
Oct 17, 2024

Conversation

y3rsh
Copy link
Member

@y3rsh y3rsh commented Oct 17, 2024

Overview

Thank you @SyntaxColoring !

OPENTRONS_VERSION was shifted to a different set of tools in the Makefile and I missed this rename.

PR 16518 changed an error message. The branch was based on a recent edge (~2 hours ago). The analyses snapshot tests ran on it and reported no mismatches.
Now that that commit has hit edge, the tests ARE reporting a mismatch.
There have been no changes to the analysis-snapshot-testing/ directory in the past week.

Test Plan and Hands on Testing

  • locally the right branch is cloned
  • In CI the right branch is cloned

See the right branch referenced in this PR

@y3rsh y3rsh self-assigned this Oct 17, 2024
@y3rsh y3rsh requested a review from a team as a code owner October 17, 2024 23:08
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY for the quick debugging!

@y3rsh y3rsh merged commit a8027f9 into edge Oct 17, 2024
11 of 12 checks passed
@y3rsh y3rsh deleted the fix-abt-makefile-to-docker-arg branch October 17, 2024 23:22
y3rsh added a commit that referenced this pull request Oct 18, 2024
## Overview

Heal edge on missed snapshot change due to #16525
TamarZanzouri pushed a commit that referenced this pull request Oct 18, 2024
## Overview

Heal edge on missed snapshot change due to #16525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants