-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shared-data, labware-library): Add eppendorf labware definitions #16241
base: edge
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #16241 +/- ##
=======================================
Coverage 73.71% 73.71%
=======================================
Files 41 41
Lines 2994 2994
=======================================
Hits 2207 2207
Misses 787 787
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few dimensions are slightly off from the drawings. Were they changed after measuring manually?
"shape": "circular", | ||
"diameter": 7, | ||
"x": 14.4, | ||
"y": 11.3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The excel sheet mentions this as 11.2mm. Was the 11.3 found out after testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why but it was generated by the Custom Labware Creater after I putted 11.2mm as the Y Offset.
}, | ||
"wells": { | ||
"A1": { | ||
"depth": 41.1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The depth calculation in the mechanical drawing is a bit confusing one calculation says 41.1mm while other is 40.9. Was this the labware that was making the tip crash a bit when moving to the bottom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it was the Eppendorf twin.tec 384 Well Plate 45 µL
labware that had a tip crash when tested on the DVT Authorship robot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the well depth is 41.1 mm giving h1 is 38.7 mm and h2 is 2.4 mm.
"diameter": 7, | ||
"x": 14.4, | ||
"y": 74.3, | ||
"z": 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the depth changes, this will change to 3.2
"xDimension": 8.2, | ||
"yDimension": 8.2, | ||
"x": 14.4, | ||
"y": 11.3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is 11.2mm in the drawing.
"shape": "circular", | ||
"diameter": 3.1, | ||
"x": 12.13, | ||
"y": 8.98, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is 8.99mm from drawings.
AUTH-697 and AUTH-698
Overview
Adding new Eppendorf labware definitions with correct module parameters and stacking offsets to shared data and Labware Library.
All new labware details can be found in this spreadsheet.
Test Plan and Hands on Testing
New Labware Testing : This spreadsheet shows all the tests I completed on each of the Eppendorf labware definitions and other new labware definitions. It also includes the LPC offset data for each new labware when placed on a Temperature Module, Magnetic Block, Heater Shaker, and/or Thermocycler Module.
Testing on Flex:
Labware Library:
Changelog
QuickTransferFlow/constants.ts
file:SINGLE_CHANNEL_COMPATIBLE_LABWARE
,EIGHT_CHANNEL_COMPATIBLE_LABWARE
, andNINETY_SIX_CHANNEL_COMPATIBLE_LABWARE
Review requests
Risk assessment