Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(app): switch ODD update modal progress bar with spinner #14838

Merged
merged 4 commits into from
Apr 9, 2024
Merged

refactor(app): switch ODD update modal progress bar with spinner #14838

merged 4 commits into from
Apr 9, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Apr 8, 2024 •
edited
Loading

closes RQA-2553

Overview

switch ODD update modal progress bar with spinner due to inconsistent blue progress fill

Test Plan

  • launch update on ODD
  • observe progress modal:
Screenshot 2024-04-09 at 1 47 46 PM

Changelog

  • remove progress bar from update modal and replace with spinner

Review requests

swappui

Risk assessment

low

@ncdiehl11 ncdiehl11 marked this pull request as ready for review April 9, 2024 17:44
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner April 9, 2024 17:44
@ncdiehl11 ncdiehl11 requested review from b-cooper, koji and jerader and removed request for a team April 9, 2024 17:44
koji
koji approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thank you for fixing!

@ncdiehl11 ncdiehl11 changed the base branch from edge to chore_release-7.2.2 April 9, 2024 18:41
@ncdiehl11 ncdiehl11 requested review from a team as code owners April 9, 2024 18:41
@ncdiehl11 ncdiehl11 requested a review from a team April 9, 2024 18:41
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner April 9, 2024 18:41
mjhuff
mjhuff requested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to target edge. Thanks!

@ncdiehl11 ncdiehl11 changed the base branch from chore_release-7.2.2 to edge April 9, 2024 18:44
@ncdiehl11 ncdiehl11 removed request for b-cooper, jerader and a team April 9, 2024 18:45
@ncdiehl11 ncdiehl11 force-pushed the refactor_app-odd-update-modal branch from 9373aca to 34a6347 Compare April 9, 2024 18:49
mjhuff
mjhuff approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for fixing this!

@ncdiehl11 ncdiehl11 merged commit 3012568 into edge Apr 9, 2024
20 checks passed
@ncdiehl11 ncdiehl11 deleted the refactor_app-odd-update-modal branch April 9, 2024 19:09
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@ncdiehl11 @Carlos-fernandez
refactor(app): switch ODD update modal progress bar with spinner (#14838
0e987f0 
)

closes RQA-2553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhuff mjhuff mjhuff approved these changes

@koji koji koji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncdiehl11 @koji @mjhuff @ncdiehl