Skip to content

Commit f0e1917

Browse files
fix(app-testing): snapshot failure capture (#15425)
1 parent de5b66f commit f0e1917

File tree

39 files changed

+897
-1335
lines changed

39 files changed

+897
-1335
lines changed

app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[041ad55e7b][OT2_S_v2_15_P300M_P20S_HS_TC_TM_dispense_changes].json

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,41 +17,37 @@
1717
"status": "succeeded"
1818
},
1919
{
20-
"commandType": "custom",
20+
"commandType": "comment",
2121
"notes": [],
2222
"params": {
23-
"legacyCommandText": "Let there be light! True 🌠🌠🌠",
24-
"legacyCommandType": "command.COMMENT"
23+
"message": "Let there be light! True 🌠🌠🌠"
2524
},
2625
"result": {},
2726
"status": "succeeded"
2827
},
2928
{
30-
"commandType": "custom",
29+
"commandType": "comment",
3130
"notes": [],
3231
"params": {
33-
"legacyCommandText": "Is the door is closed? True 🚪🚪🚪",
34-
"legacyCommandType": "command.COMMENT"
32+
"message": "Is the door is closed? True 🚪🚪🚪"
3533
},
3634
"result": {},
3735
"status": "succeeded"
3836
},
3937
{
40-
"commandType": "custom",
38+
"commandType": "comment",
4139
"notes": [],
4240
"params": {
43-
"legacyCommandText": "Is this a simulation? True 🔮🔮🔮",
44-
"legacyCommandType": "command.COMMENT"
41+
"message": "Is this a simulation? True 🔮🔮🔮"
4542
},
4643
"result": {},
4744
"status": "succeeded"
4845
},
4946
{
50-
"commandType": "custom",
47+
"commandType": "comment",
5148
"notes": [],
5249
"params": {
53-
"legacyCommandText": "Running against API Version: 2.15",
54-
"legacyCommandType": "command.COMMENT"
50+
"message": "Running against API Version: 2.15"
5551
},
5652
"result": {},
5753
"status": "succeeded"

app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[0affe60373][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum].json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"errorInfo": {
2222
"args": "(\"Maximum is type 'str', but must be of parameter type 'int'\",)",
2323
"class": "ParameterDefinitionError",
24-
"traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"<string>\", line 1, in <module>\n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum.py\", line 104, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 199, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 94, in __init__\n validation.validate_options(default, minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 266, in validate_options\n _validate_min_and_max(minimum, maximum, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 218, in _validate_min_and_max\n raise ParameterDefinitionError(\n"
24+
"traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"<string>\", line 1, in <module>\n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum.py\", line 104, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 200, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 95, in __init__\n validation.validate_options(default, minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 266, in validate_options\n _validate_min_and_max(minimum, maximum, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 218, in _validate_min_and_max\n raise ParameterDefinitionError(\n"
2525
},
2626
"errorType": "PythonException",
2727
"isDefined": false,

app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[0c4ae179bb][OT2_S_v2_15_P300M_P20S_HS_TC_TM_SmokeTestV3].json

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,41 +17,37 @@
1717
"status": "succeeded"
1818
},
1919
{
20-
"commandType": "custom",
20+
"commandType": "comment",
2121
"notes": [],
2222
"params": {
23-
"legacyCommandText": "Let there be light! True 🌠🌠🌠",
24-
"legacyCommandType": "command.COMMENT"
23+
"message": "Let there be light! True 🌠🌠🌠"
2524
},
2625
"result": {},
2726
"status": "succeeded"
2827
},
2928
{
30-
"commandType": "custom",
29+
"commandType": "comment",
3130
"notes": [],
3231
"params": {
33-
"legacyCommandText": "Is the door is closed? True 🚪🚪🚪",
34-
"legacyCommandType": "command.COMMENT"
32+
"message": "Is the door is closed? True 🚪🚪🚪"
3533
},
3634
"result": {},
3735
"status": "succeeded"
3836
},
3937
{
40-
"commandType": "custom",
38+
"commandType": "comment",
4139
"notes": [],
4240
"params": {
43-
"legacyCommandText": "Is this a simulation? True 🔮🔮🔮",
44-
"legacyCommandType": "command.COMMENT"
41+
"message": "Is this a simulation? True 🔮🔮🔮"
4542
},
4643
"result": {},
4744
"status": "succeeded"
4845
},
4946
{
50-
"commandType": "custom",
47+
"commandType": "comment",
5148
"notes": [],
5249
"params": {
53-
"legacyCommandText": "Running against API Version: 2.15",
54-
"legacyCommandType": "command.COMMENT"
50+
"message": "Running against API Version: 2.15"
5551
},
5652
"result": {},
5753
"status": "succeeded"

0 commit comments

Comments
 (0)