From c36ceef08e36eaa0eb8ce1a81224eae9a51f6256 Mon Sep 17 00:00:00 2001 From: Max Marrone Date: Wed, 23 Oct 2024 18:48:41 -0400 Subject: [PATCH] Use placeholder implementation instead of raising NotImplementedError. This seems a little more friendly to UI tests. --- robot-server/robot_server/runs/error_recovery_mapping.py | 2 +- robot-server/robot_server/runs/run_controller.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/robot-server/robot_server/runs/error_recovery_mapping.py b/robot-server/robot_server/runs/error_recovery_mapping.py index 8832917778a..b548394cd8a 100644 --- a/robot-server/robot_server/runs/error_recovery_mapping.py +++ b/robot-server/robot_server/runs/error_recovery_mapping.py @@ -105,7 +105,7 @@ def _map_error_recovery_type(reaction_if_match: ReactionIfMatch) -> ErrorRecover case ReactionIfMatch.ASSUME_FALSE_POSITIVE_AND_CONTINUE: # todo(mm, 2024-10-23): Connect to work in # https://github.com/Opentrons/opentrons/pull/16556. - raise NotImplementedError + return ErrorRecoveryType.IGNORE_AND_CONTINUE case ReactionIfMatch.FAIL_RUN: return ErrorRecoveryType.FAIL_RUN case ReactionIfMatch.WAIT_FOR_RECOVERY: diff --git a/robot-server/robot_server/runs/run_controller.py b/robot-server/robot_server/runs/run_controller.py index d5bc51a11c0..1619cd20a08 100644 --- a/robot-server/robot_server/runs/run_controller.py +++ b/robot-server/robot_server/runs/run_controller.py @@ -103,7 +103,7 @@ def create_action( ): # todo(mm, 2024-10-23): Connect to work in # https://github.com/Opentrons/opentrons/pull/16556. - raise NotImplementedError + self._run_orchestrator_store.resume_from_recovery() else: assert_never(action_type)