Skip to content

Commit 95a656f

Browse files
authored
fix(app): filter robots for CSV protocols that raise analysis errors (#16145)
We are intentionally permissive of robots on which to start protocol setup if analysis fails app-side. However, we previously checked whether the analysis contained errors to make this determination. Given that CSV parameter protocols raise analysis errors intentionally, but contain useful information regarding the robot type, we should filter robots if the analysis result is `parameter-value-required`. Closes RQA-3114
1 parent f5e3317 commit 95a656f

File tree

1 file changed

+2
-2
lines changed
  • app/src/organisms/ChooseRobotToRunProtocolSlideout

1 file changed

+2
-2
lines changed

app/src/organisms/ChooseRobotToRunProtocolSlideout/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,9 +204,9 @@ export function ChooseRobotToRunProtocolSlideoutComponent(
204204
first(srcFileNames) ??
205205
protocolKey
206206

207-
// intentionally show both robot types if analysis has any error
207+
// intentionally show both robot types if analysis fails
208208
const robotType =
209-
mostRecentAnalysis != null && mostRecentAnalysis.errors.length === 0
209+
mostRecentAnalysis != null && mostRecentAnalysis.result !== 'not-ok'
210210
? mostRecentAnalysis?.robotType ?? null
211211
: null
212212

0 commit comments

Comments
 (0)