Skip to content

Commit 91b3722

Browse files
committed
go back to using yarn
1 parent b3dac06 commit 91b3722

File tree

26 files changed

+19376
-24108
lines changed

26 files changed

+19376
-24108
lines changed

Makefile

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -47,16 +47,16 @@ endif
4747

4848
# run at usage (=), not on makefile parse (:=)
4949
# todo(mm, 2021-03-17): Deduplicate with scripts/python.mk.
50-
usb_host=$(shell pnpm -s discovery find -i 169.254)
50+
usb_host=$(shell yarn -s discovery find -i 169.254)
5151

5252
# install all project dependencies
5353
.PHONY: setup
5454
setup: setup-js setup-py
5555

56-
# front-end dependecies handled by pnpm
56+
# front-end dependecies handled by yarn
5757
.PHONY: setup-js
5858
setup-js:
59-
pnpm i
59+
yarn
6060
$(MAKE) -C $(APP_SHELL_DIR) setup
6161
$(MAKE) -C $(APP_SHELL_ODD_DIR) setup
6262

@@ -80,7 +80,7 @@ teardown:
8080

8181
.PHONY: teardown-js
8282
teardown-js: clean-js
83-
pnpm shx rm -rf "**/node_modules"
83+
yarn shx rm -rf "**/node_modules"
8484

8585
PYTHON_TEARDOWN_TARGETS := $(addsuffix -py-teardown, $(PYTHON_DIRS))
8686

@@ -208,16 +208,16 @@ lint-py: $(PYTHON_LINT_TARGETS)
208208

209209
.PHONY: lint-js
210210
lint-js:
211-
pnpm eslint --quiet=$(quiet) ".*.@(js|ts|tsx)" "**/*.@(js|ts|tsx)"
212-
pnpm prettier --ignore-path .eslintignore --check $(FORMAT_FILE_GLOB)
211+
yarn eslint --quiet=$(quiet) ".*.@(js|ts|tsx)" "**/*.@(js|ts|tsx)"
212+
yarn prettier --ignore-path .eslintignore --check $(FORMAT_FILE_GLOB)
213213

214214
.PHONY: lint-json
215215
lint-json:
216-
pnpm eslint --max-warnings 0 --ext .json .
216+
yarn eslint --max-warnings 0 --ext .json .
217217

218218
.PHONY: lint-css
219219
lint-css:
220-
pnpm stylelint "**/*.css" "**/*.js"
220+
yarn stylelint "**/*.css" "**/*.js"
221221

222222
.PHONY: format
223223
format: format-js format-py
@@ -232,31 +232,31 @@ format-py: $(PYTHON_FORMAT_TARGETS)
232232

233233
.PHONY: format-js
234234
format-js:
235-
pnpm prettier --ignore-path .eslintignore --write $(FORMAT_FILE_GLOB)
235+
yarn prettier --ignore-path .eslintignore --write $(FORMAT_FILE_GLOB)
236236

237237
.PHONY: check-js
238238
check-js: build-ts
239239

240240
.PHONY: build-ts
241241
build-ts:
242-
pnpm tsc --build
242+
yarn tsc --build
243243

244244
.PHONY: clean-ts
245245
clean-ts:
246-
pnpm tsc --build --clean
246+
yarn tsc --build --clean
247247

248248
# TODO: Ian 2019-12-17 gradually add components and shared-data
249249
.PHONY: circular-dependencies-js
250250
circular-dependencies-js:
251-
pnpm madge $(and $(CI),--no-spinner --no-color) --circular protocol-designer/src/index.tsx
252-
pnpm madge $(and $(CI),--no-spinner --no-color) --circular step-generation/src/index.ts
253-
pnpm madge $(and $(CI),--no-spinner --no-color) --circular labware-library/src/index.tsx
254-
pnpm madge $(and $(CI),--no-spinner --no-color) --circular app/src/index.tsx
255-
pnpm madge $(and $(CI),--no-spinner --no-color) --circular components/src/index.ts
251+
yarn madge $(and $(CI),--no-spinner --no-color) --circular protocol-designer/src/index.tsx
252+
yarn madge $(and $(CI),--no-spinner --no-color) --circular step-generation/src/index.ts
253+
yarn madge $(and $(CI),--no-spinner --no-color) --circular labware-library/src/index.tsx
254+
yarn madge $(and $(CI),--no-spinner --no-color) --circular app/src/index.tsx
255+
yarn madge $(and $(CI),--no-spinner --no-color) --circular components/src/index.ts
256256

257257
.PHONY: test-js-internal
258258
test-js-internal:
259-
pnpm jest $(tests) $(test_opts) $(cov_opts)
259+
yarn jest $(tests) $(test_opts) $(cov_opts)
260260

261261
.PHONY: test-js-%
262262
test-js-%:

api-client/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# opentrons api-client makefile
22

33
# using bash instead of /bin/bash in SHELL prevents macOS optimizing away our PATH update
4-
# TODO(mc, 2021-02-12): this may be unnecessary by using `pnpm run` instead
4+
# TODO(mc, 2021-02-12): this may be unnecessary by using `yarn run` instead
55
SHELL := bash
66

77
# standard targets
@@ -12,7 +12,7 @@ all: clean build
1212

1313
.PHONY: clean
1414
clean:
15-
tsc --build --clean && pnpm shx rm -rf \"dist\"
15+
tsc --build --clean && yarn shx rm -rf \"dist\"
1616

1717
.PHONY: build
1818
build:

app-shell-odd/Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ include ../scripts/push.mk
66
SHELL := bash
77

88
# add node_modules/.bin to PATH
9-
PATH := $(shell cd .. && pnpm bin):$(PATH)
9+
PATH := $(shell cd .. && yarn bin):$(PATH)
1010

1111
# dev server port
1212
PORT ?= 5173
@@ -21,11 +21,11 @@ noop := cd .
2121
# Other SSH args for robots
2222
ssh_opts ?= $(default_ssh_opts)
2323

24-
builder := pnpm electron-builder \
24+
builder := yarn electron-builder \
2525
--config electron-builder.config.js \
2626
--publish never
2727

28-
electron := pnpm electron . \
28+
electron := yarn electron . \
2929
--devtools \
3030
--log.level.console="debug" \
3131
--disable_ui.webPreferences.webSecurity \
@@ -41,10 +41,10 @@ OPENTRONS_PROJECT ?= robot-stack
4141
all: package
4242

4343
.PHONY: setup
44-
# must be wrapped in pnpm run otherwise `prebuild-install` will fail silently
44+
# must be wrapped in yarn run otherwise `prebuild-install` will fail silently
4545
# due to how `electron-rebuild` calls `prebuild-install`
4646
setup:
47-
pnpm rebuild
47+
yarn rebuild
4848

4949
.PHONY: clean
5050
clean:

app-shell/Makefile

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ include ../scripts/push.mk
66
SHELL := bash
77

88
# add node_modules/.bin to PATH
9-
PATH := $(shell cd .. && pnpm bin):$(PATH)
9+
PATH := $(shell cd .. && yarn bin):$(PATH)
1010

1111
# dev server port
1212
PORT ?= 3000
@@ -57,13 +57,13 @@ OPENTRONS_PROJECT ?= $(if $(filter ot3@%,$(publish_update)),ot3,robot-stack)
5757
# make dist no_python_bundle=true or =1 or whatever
5858
no_python_bundle ?=
5959

60-
builder := pnpm electron-builder \
60+
builder := yarn electron-builder \
6161
--config electron-builder.config.js \
62-
--config.electronVersion=23.3.13 \
62+
--config.electronVersion=27.0.0 \
6363
--publish never
6464

6565

66-
electron := pnpm electron . \
66+
electron := yarn electron . \
6767
--devtools \
6868
--log.level.console="debug" \
6969
--disable_ui.webPreferences.webSecurity \
@@ -82,14 +82,14 @@ branch-suffix:
8282
all: package
8383

8484
.PHONY: setup
85-
# must be wrapped in pnpm run otherwise `prebuild-install` will fail silently
85+
# must be wrapped in yarn run otherwise `prebuild-install` will fail silently
8686
# due to how `electron-rebuild` calls `prebuild-install`
8787
setup:
88-
pnpm i
88+
yarn rebuild
8989

9090
.PHONY: clean
9191
clean:
92-
shx rm -rf lib dist python
92+
yarn shx rm -rf lib dist python
9393

9494
# artifacts
9595
#####################################################################

app-shell/electron-builder.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const publishConfig =
2525
module.exports = async () => ({
2626
appId:
2727
project === 'robot-stack' ? 'com.opentrons.app' : 'com.opentrons.appot3',
28-
electronVersion: '23.3.13',
28+
electronVersion: '27.0.0',
2929
npmRebuild: false,
3030
releaseInfo: {
3131
releaseNotesFile:

app-testing/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ teardown:
4848

4949
.PHONY: format-readme
5050
format-readme:
51-
pnpm prettier --ignore-path .eslintignore --write app-testing/**/*.md
51+
yarn prettier --ignore-path .eslintignore --write app-testing/**/*.md
5252

5353
.PHONY: print-protocols
5454
print-protocols:

app/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
SHELL := bash
55

66
# add node_modules/.bin to PATH
7-
PATH := $(shell cd .. && pnpm bin):$(PATH)
7+
PATH := $(shell cd .. && yarn bin):$(PATH)
88

99
# dev server port
1010
PORT ?= 5173
@@ -35,7 +35,7 @@ all: clean dist
3535

3636
.PHONY: setup
3737
setup:
38-
pnpm i
38+
yarn
3939

4040
.PHONY: clean
4141
clean:

components/Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,26 +17,26 @@ all: clean dist
1717

1818
.PHONY: clean
1919
clean:
20-
cd .. && pnpm shx rm -rf storybook-static
20+
cd .. && yarn shx rm -rf storybook-static
2121

2222
# artifacts
2323
#####################################################################
2424

2525
.PHONY: dist
2626
dist:
27-
cd .. && pnpm sb build
27+
cd .. && yarn sb build
2828

2929
.PHONY: lib
3030
lib: export NODE_ENV := production
3131
lib:
32-
pnpm vite build
32+
yarn vite build
3333

3434
# development
3535
#####################################################################
3636

3737
.PHONY: dev
3838
dev:
39-
cd .. && pnpm sb dev --port $(port)
39+
cd .. && yarn sb dev --port $(port)
4040

4141
.PHONY: test
4242
test:

discovery-client/Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# opentrons discovery-client makefile
22

33
# using bash instead of /bin/bash in SHELL prevents macOS optimizing away our PATH update
4-
# TODO(mc, 2021-02-12): this may be unnecessary by using `pnpm run` instead
4+
# TODO(mc, 2021-02-12): this may be unnecessary by using `yarn run` instead
55
SHELL := bash
66

77
# outputs
@@ -16,7 +16,7 @@ all: clean lib
1616

1717
.PHONY: clean
1818
clean:
19-
pnpm shx rm -rf $(main_out) $(cli_out)
19+
yarn shx rm -rf $(main_out) $(cli_out)
2020

2121
# artifacts
2222
#####################################################################
@@ -26,7 +26,7 @@ lib: export NODE_ENV := production
2626
lib: $(main_out) $(cli_out)
2727

2828
$(main_out) $(cli_out):
29-
pnpm vite build
29+
yarn vite build
3030

3131
.PHONY: test
3232
test:

g-code-testing/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,9 @@ FORMAT_FILE_GLOB = "g-code-testing/**/*.@(json|md|yml|yaml)"
100100
.PHONY: format-other
101101
format-other:
102102
cd ..
103-
pnpm prettier --ignore-path .eslintignore --write $(FORMAT_FILE_GLOB)
103+
yarn prettier --ignore-path .eslintignore --write $(FORMAT_FILE_GLOB)
104104

105105
.PHONY: lint-other
106106
lint-other:
107107
cd ..
108-
pnpm prettier --check --ignore-path .eslintignore $(FORMAT_FILE_GLOB)
108+
yarn prettier --check --ignore-path .eslintignore $(FORMAT_FILE_GLOB)

0 commit comments

Comments
 (0)