Skip to content

Commit

Permalink
feat(hardware): add SN support for the P1KP pipette
Browse files Browse the repository at this point in the history
  • Loading branch information
ryanthecoder committed Nov 20, 2024
1 parent 54a4017 commit 908df40
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1008,6 +1008,7 @@ def _lookup_serial_key(pipette_name: FirmwarePipetteName) -> str:
lookup_name = {
FirmwarePipetteName.p1000_single: "P1KS",
FirmwarePipetteName.p1000_multi: "P1KM",
FirmwarePipetteName.p1000_multi_emulsify: "P1KP",
FirmwarePipetteName.p50_single: "P50S",
FirmwarePipetteName.p50_multi: "P50M",
FirmwarePipetteName.p1000_96: "P1KH",
Expand Down
1 change: 1 addition & 0 deletions hardware/opentrons_hardware/firmware_bindings/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,7 @@ class PipetteName(int, Enum):
p1000_96 = 0x04
p50_96 = 0x05
p200_96 = 0x06
p1000_multi_emulsify = 0x07
unknown = 0xFFFF


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
NAME_LOOKUP: Dict[str, PipetteName] = {
"P1KS": PipetteName.p1000_single,
"P1KM": PipetteName.p1000_multi,
"P1KP": PipetteName.p1000_multi_emulsify,
"P50S": PipetteName.p50_single,
"P50M": PipetteName.p50_multi,
"P1KH": PipetteName.p1000_96,
Expand Down
6 changes: 6 additions & 0 deletions hardware/tests/opentrons_hardware/instruments/test_serials.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@
1,
b"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00",
),
(
"P1KPV30",
PipetteName.p1000_multi_emulsify,
30,
b"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00",
),
],
)
def test_scan_valid_pipette_serials(
Expand Down
2 changes: 1 addition & 1 deletion shared-data/js/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export const OT3_PIPETTES = [
'p20_single_flex',
'p50_single_flex',
'p50_multi_flex',
'p1000_multi_flex',
'p1000_multi_emulsify_flex',
'p1000_96',
'p200_96',
]
Expand Down
2 changes: 2 additions & 0 deletions shared-data/python/opentrons_shared_data/pipette/dev_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"p1000_single_gen2",
"p1000_single_flex",
"p1000_multi_flex",
"p1000_multi_emulsify_flex",
"p1000_96",
"p200_96",
]
Expand All @@ -57,6 +58,7 @@ class PipetteNameType(str, Enum):
P1000_SINGLE_GEN2 = "p1000_single_gen2"
P1000_SINGLE_FLEX = "p1000_single_flex"
P1000_MULTI_FLEX = "p1000_multi_flex"
P1000_MULTI_EMULSIFY_FLEX = "p1000_multi_emulsify_flex"
P1000_96 = "p1000_96"
P200_96 = "p200_96"

Expand Down
4 changes: 2 additions & 2 deletions shared-data/python/opentrons_shared_data/pipette/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def dict_for_encode(self) -> bool:
"p1000_single_gen2",
"p1000_single_flex",
"p1000_multi_flex",
"p1000_multi_emulsify",
"p1000_multi_emulsify_flex",
"p1000_96",
"p200_96",
]
Expand All @@ -243,7 +243,7 @@ class PipetteNameType(str, enum.Enum):
P1000_SINGLE_GEN2 = "p1000_single_gen2"
P1000_SINGLE_FLEX = "p1000_single_flex"
P1000_MULTI_FLEX = "p1000_multi_flex"
P1000_MULTI_EMULSIFY = "p1000_multi_emulsify"
P1000_MULTI_EMULSIFY_FLEX = "p1000_multi_emulsify_flex"
P1000_96 = "p1000_96"
P200_96 = "p200_96"

Expand Down

0 comments on commit 908df40

Please sign in to comment.