From 77071bf99e26c1ef47591ad3f8cc41596ba0fb88 Mon Sep 17 00:00:00 2001 From: Seth Foster Date: Tue, 15 Aug 2023 16:22:50 -0400 Subject: [PATCH] chore: upload artifacts separate because globs (#13308) I don't think this action likes having multiple globs as an artifact target, so do the three separately. --- .github/workflows/app-test-build-deploy.yaml | 26 ++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/.github/workflows/app-test-build-deploy.yaml b/.github/workflows/app-test-build-deploy.yaml index b8b5b7d32d8..cee26372bf5 100644 --- a/.github/workflows/app-test-build-deploy.yaml +++ b/.github/workflows/app-test-build-deploy.yaml @@ -348,7 +348,7 @@ jobs: - name: 'deploy internal-release release builds to s3' run: | aws s3 --profile=deploy sync --acl=public-read to_upload_internal-release/ s3://${{ env._APP_DEPLOY_BUCKET_OT3 }}/${{ env._APP_DEPLOY_FOLDER_OT3 }} - - name: 'upload artifacts to GH release' + - name: 'upload windows artifacts to GH release' uses: 'ncipollo/release-action@v1.12.0' if: needs.determine-build-type.outputs.type == 'release' with: @@ -357,7 +357,29 @@ jobs: omitDraftDuringUpdate: true omitNameDuringUpdate: true omitPrereleaseDuringUpdate: true - artifacts: ./artifacts/*/*.exe ./artifacts/*/*.dmg ./artifacts/*/*.AppImage + artifacts: ./artifacts/*/*.exe + artifactContentType: application/vnd.microsoft.portable-executable + - name: 'upload macos artifacts to GH release' + uses: 'ncipollo/release-action@v1.12.0' + if: needs.determine-build-type.outputs.type == 'release' + with: + allowUpdates: true + omitBodyDuringUpdate: true + omitDraftDuringUpdate: true + omitNameDuringUpdate: true + omitPrereleaseDuringUpdate: true + artifacts: ./artifacts/*/*.dmg + artifactContentType: application/octet-stream + - name: 'upload linux artifacts to GH release' + uses: 'ncipollo/release-action@v1.12.0' + if: needs.determine-build-type.outputs.type == 'release' + with: + allowUpdates: true + omitBodyDuringUpdate: true + omitDraftDuringUpdate: true + omitNameDuringUpdate: true + omitPrereleaseDuringUpdate: true + artifacts: ./artifacts/*/*.AppImage artifactContentType: application/octet-stream - name: 'detect build data for notification' id: names