-
Notifications
You must be signed in to change notification settings - Fork 179
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: upload artifacts separate because globs (#13308)
I don't think this action likes having multiple globs as an artifact target, so do the three separately.
- Loading branch information
Showing
1 changed file
with
24 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -348,7 +348,7 @@ jobs: | |
- name: 'deploy internal-release release builds to s3' | ||
run: | | ||
aws s3 --profile=deploy sync --acl=public-read to_upload_internal-release/ s3://${{ env._APP_DEPLOY_BUCKET_OT3 }}/${{ env._APP_DEPLOY_FOLDER_OT3 }} | ||
- name: 'upload artifacts to GH release' | ||
- name: 'upload windows artifacts to GH release' | ||
uses: 'ncipollo/[email protected]' | ||
if: needs.determine-build-type.outputs.type == 'release' | ||
with: | ||
|
@@ -357,7 +357,29 @@ jobs: | |
omitDraftDuringUpdate: true | ||
omitNameDuringUpdate: true | ||
omitPrereleaseDuringUpdate: true | ||
artifacts: ./artifacts/*/*.exe ./artifacts/*/*.dmg ./artifacts/*/*.AppImage | ||
artifacts: ./artifacts/*/*.exe | ||
artifactContentType: application/vnd.microsoft.portable-executable | ||
- name: 'upload macos artifacts to GH release' | ||
uses: 'ncipollo/[email protected]' | ||
if: needs.determine-build-type.outputs.type == 'release' | ||
with: | ||
allowUpdates: true | ||
omitBodyDuringUpdate: true | ||
omitDraftDuringUpdate: true | ||
omitNameDuringUpdate: true | ||
omitPrereleaseDuringUpdate: true | ||
artifacts: ./artifacts/*/*.dmg | ||
artifactContentType: application/octet-stream | ||
- name: 'upload linux artifacts to GH release' | ||
uses: 'ncipollo/[email protected]' | ||
if: needs.determine-build-type.outputs.type == 'release' | ||
with: | ||
allowUpdates: true | ||
omitBodyDuringUpdate: true | ||
omitDraftDuringUpdate: true | ||
omitNameDuringUpdate: true | ||
omitPrereleaseDuringUpdate: true | ||
artifacts: ./artifacts/*/*.AppImage | ||
artifactContentType: application/octet-stream | ||
- name: 'detect build data for notification' | ||
id: names | ||
|