Skip to content

Commit

Permalink
fix app dependencies for app production builds
Browse files Browse the repository at this point in the history
  • Loading branch information
shlokamin committed Feb 26, 2024
1 parent c8d2f4b commit 3eeb478
Show file tree
Hide file tree
Showing 5 changed files with 50 additions and 86 deletions.
2 changes: 2 additions & 0 deletions app-shell/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"@types/pump": "^1.1.0",
"@types/uuid": "^3.4.7",
"ajv": "6.12.3",
"axios": "^0.21.1",
"dateformat": "3.0.3",
"electron-context-menu": "3.6.1",
"electron-debug": "3.0.1",
Expand All @@ -54,6 +55,7 @@
"form-data": "2.5.0",
"fs-extra": "10.0.0",
"get-stream": "5.1.0",
"lodash": "4.17.21",
"merge-options": "1.0.1",
"mqtt": "4.3.8",
"node-fetch": "2.6.7",
Expand Down
6 changes: 5 additions & 1 deletion app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@
"@types/mixpanel-browser": "^2.35.6",
"@types/node-fetch": "2.6.11",
"@types/styled-components": "^5.1.26",
"axios": "^0.21.1"
"axios": "^0.21.1",
"postcss-apply": "0.12.0",
"postcss-color-mod-function": "3.0.3",
"postcss-import": "16.0.0",
"postcss-preset-env": "9.3.0"
}
}
6 changes: 2 additions & 4 deletions app/src/redux/shell/remote.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
// access main process remote modules via attachments to `global`

import assert from 'assert'
import { EventEmitter } from 'events'

import type { AxiosRequestConfig } from 'axios'
Expand All @@ -11,12 +9,12 @@ const emptyRemote: Remote = {} as any

export const remote: Remote = new Proxy(emptyRemote, {
get(_target, propName: string): unknown {
assert(
console.assert(
(global as any).APP_SHELL_REMOTE,
'Expected APP_SHELL_REMOTE to be attached to global scope; is app-shell/src/preload.ts properly configured?'
)

assert(
console.assert(
propName in (global as any).APP_SHELL_REMOTE,
`Expected APP_SHELL_REMOTE.${propName} to exist, is app-shell/src/preload.ts properly configured?`
)
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"devDependencies": {
"@cypress/webpack-preprocessor": "^5.1.2",
"@electron/rebuild": "3.3.0",
"@electron/rebuild": "3.2.10",
"@octokit/rest": "^19.0.5",
"@rollup/plugin-alias": "^3.1.2",
"@rollup/plugin-babel": "^5.3.0",
Expand Down
Loading

0 comments on commit 3eeb478

Please sign in to comment.