fix(protocol-designer): candidate-C bug addressing and don't unnecess… (#15258)

…arily migrate

closes RQA-2772 RQA-2773 RQA-2776 RQA-2777

Author: jerader

protocol-designer/src/components/FilePage.tsx

@@ -82,6 +82,7 @@ export const FilePage = (): JSX.Element => {
 
   const saveFileMetadata = (nextFormValues: FileMetadataFields): void => {
     dispatch(actions.saveFileMetadata(nextFormValues))
+    setManualDirty(false)
   }
   const [isManualDirty, setManualDirty] = React.useState<boolean>(false)
   const {
@@ -114,7 +115,6 @@ export const FilePage = (): JSX.Element => {
     'author',
     'description',
   ])
-
   return (
     <div className={styles.file_page}>
       <Card title={t('application:information')}>
@@ -201,7 +201,6 @@ export const FilePage = (): JSX.Element => {
               type="submit"
               className={styles.update_button}
               disabled={!isDirty || !isManualDirty}
-              onClick={() => setManualDirty(false)}
             >
               {isManualDirty
                 ? t('application:update')

protocol-designer/src/components/FileSidebar/utils/getUnusedTrash.ts

@@ -38,13 +38,17 @@ export const getUnusedTrash = (
     wasteChute != null
       ? commands?.some(
           command =>
-            command.commandType === 'moveToAddressableArea' &&
-            WASTE_CHUTE_ADDRESSABLE_AREAS.includes(
-              command.params.addressableAreaName as AddressableAreaName
-            )
+            (command.commandType === 'moveToAddressableArea' &&
+              WASTE_CHUTE_ADDRESSABLE_AREAS.includes(
+                command.params.addressableAreaName as AddressableAreaName
+              )) ||
+            (command.commandType === 'moveLabware' &&
+              command.params.newLocation !== 'offDeck' &&
+              'addressableAreaName' in command.params.newLocation &&
+              command.params.newLocation.addressableAreaName ===
+                'gripperWasteChute')
         )
       : null
-
   return {
     trashBinUnused: trashBin != null && !hasTrashBinCommands,
     wasteChuteUnused: wasteChute != null && !hasWasteChuteCommands,

protocol-designer/src/components/modals/CreateFileWizard/index.tsx

@@ -121,6 +121,7 @@ export function CreateFileWizard(): JSX.Element | null {
       values.pipettesByMount,
       (acc, formPipette: FormPipette, mount): PipetteFieldsData[] => {
         return formPipette?.pipetteName != null &&
+          formPipette?.pipetteName !== '' &&
           formPipette.tiprackDefURI != null &&
           (mount === 'left' || mount === 'right')
           ? [

protocol-designer/src/load-file/migration/index.ts

@@ -27,7 +27,11 @@ export const getMigrationVersionsToRunFromVersion = (
   const allSortedVersions = Object.keys(migrationsByVersion).sort(
     semver.compare
   )
-  return takeRightWhile(allSortedVersions, v => semver.gt(v, version))
+
+  return takeRightWhile(
+    allSortedVersions,
+    v => semver.gt(v, version) && !version.includes(v)
+  )
 }
 
 const allMigrationsByVersion: MigrationsByVersion = {

protocol-designer/src/step-forms/reducers/index.ts

@@ -1355,10 +1355,9 @@ export const additionalEquipmentInvariantProperties = handleActions<NormalizedAd
             command.params.newLocation !== 'offDeck' &&
             'addressableAreaName' in command.params.newLocation &&
             WASTE_CHUTE_ADDRESSABLE_AREAS.includes(
-              command.params.addressableAreaName
+              command.params.newLocation.addressableAreaName
             ))
       )
-
       const getStagingAreaSlotNames = (
         commandType: 'moveLabware' | 'loadLabware',
         locationKey: 'newLocation' | 'location'
@@ -1519,6 +1518,9 @@ export const additionalEquipmentInvariantProperties = handleActions<NormalizedAd
         ) {
           wasteChuteId = moveLiquidStepWasteChute.blowOut_location
         }
+        //  new wasteChuteId generated for if there are only moveLabware commands
+      } else if (hasWasteChuteCommands && moveLiquidStepWasteChute == null) {
+        wasteChuteId = `${uuid()}:wasteChute`
       }
 
       const wasteChute =