Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(thermocycler): automate offset tuning, make 'stat' response immediate #107

Closed
wants to merge 26 commits into from

Conversation

sanni-t
Copy link
Member

@sanni-t sanni-t commented Feb 10, 2020

Closes #98

overview

TC offset tuning tunes the thermocycler offsets to keep the TC plate temperatures within the specs. Tunes the B & C offsets according to this doc: https://docs.google.com/document/d/14exU49dWMJCu1ZlC0dI2caO9682fbA5z1bPjl2HYyDk/

changes

  • added offset tuning QC script
  • made debug stat gcode respond immediately instead of with a delay. (The delay was between two consecutive responses and not between the time the gcode was received & the time its response was sent)

review requests

  • make sure the code looks good
  • make sure the tuning works as expected

Notes: script takes 2 args: -L for log level (default INFO) and -p for thermometer port name (eg., -p=COM10). It saves the logs to a file in the current directory with the unit's serial number as the name

@sanni-t sanni-t mentioned this pull request Nov 20, 2020
@fsinapi fsinapi closed this Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thermocycler: automate offset tuning process
3 participants