-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(thermocycler): automate offset tuning, make 'stat' response immediate #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rance of +-0.2C; flag for adjusting b_offset
…open from cooldown
…ust c_offset at 70C with 0.009 tolerance; only restabilize everything twice if c is adjusted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98
overview
TC offset tuning tunes the thermocycler offsets to keep the TC plate temperatures within the specs. Tunes the B & C offsets according to this doc: https://docs.google.com/document/d/14exU49dWMJCu1ZlC0dI2caO9682fbA5z1bPjl2HYyDk/
changes
stat
gcode respond immediately instead of with a delay. (The delay was between two consecutive responses and not between the time the gcode was received & the time its response was sent)review requests
Notes: script takes 2 args: -L for log level (default INFO) and -p for thermometer port name (eg.,
-p=COM10
). It saves the logs to a file in the current directory with the unit's serial number as the name