fix: emit OTP do not attemp to create password reset link if user is not verified

smarcet · smarcet · commit 2c5ca3127a05 · 2025-09-11T14:42:22.000-03:00
diff --git a/app/Strategies/OTP/OTPChannelEmailStrategy.php b/app/Strategies/OTP/OTPChannelEmailStrategy.php
@@ -61,13 +61,13 @@ public function send(IOTPTypeBuilderStrategy $typeBuilderStrategy, OAuth2OTP $ot
         try{
             $reset_password_link = null;
             $user = $this->user_repository->getByEmailOrName($otp->getUserName());
-            if($user instanceof User && !$user->hasPasswordSet()){
+            if($user instanceof User && !$user->hasPasswordSet() && $user->isEmailVerified()){
                 // create a password reset request
                 Log::debug
                 (
                     sprintf
                     (
-                        "OTPChannelEmailStrategy::send user %s has no password set",
+                        "OTPChannelEmailStrategy::send user %s has no password set, trying to generate a reset link ...",
                         $user->getId()
                     )
                 );

Original file line number	Diff line number	Diff line change
`@@ -61,13 +61,13 @@ public function send(IOTPTypeBuilderStrategy $typeBuilderStrategy, OAuth2OTP $ot`
`61`	`61`	`try{`
`62`	`62`	`$reset_password_link = null;`
`63`	`63`	`$user = $this->user_repository->getByEmailOrName($otp->getUserName());`
`64`		`- if($user instanceof User && !$user->hasPasswordSet()){`
	`64`	`+ if($user instanceof User && !$user->hasPasswordSet() && $user->isEmailVerified()){`
`65`	`65`	`// create a password reset request`
`66`	`66`	`Log::debug`
`67`	`67`	`(`
`68`	`68`	`sprintf`
`69`	`69`	`(`
`70`		`- "OTPChannelEmailStrategy::send user %s has no password set",`
	`70`	`+ "OTPChannelEmailStrategy::send user %s has no password set, trying to generate a reset link ...",`
`71`	`71`	`$user->getId()`
`72`	`72`	`)`
`73`	`73`	`);`