Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed copy url button from home page #59

Closed
wants to merge 5 commits into from

Conversation

Hat52
Copy link
Contributor

@Hat52 Hat52 commented Mar 23, 2023

Pull Request Checklist

Before submitting a pull request, please make sure that your changes meet the following criteria:

  • Ensure that your code adheres to our coding conventions and is properly formatted.
  • Test your changes extensively to ensure that they do not introduce any new bugs.
  • Confirm that you agree to the code of conduct.

Related Issues

Closes #37

Screenshots

image

Additional Notes

No

@netlify
Copy link

netlify bot commented Mar 23, 2023

Deploy Preview for ygc failed.

Name Link
🔨 Latest commit 7482bf2
🔍 Latest deploy log https://app.netlify.com/sites/ygc/deploys/6522464f4ec2550008b00623

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

We will review your submission soon and give you helpful feedback. If you think it's something urgent, feel free to reach out Sachin Chaurasiya on LinkedIn. Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!

@Sachin-chaurasiya
Copy link
Member

Hello @Hat52 , thanks for the PR.

Build is failing due to some linting errors can you check?

@Sachin-chaurasiya
Copy link
Member

Hello @Hat52, Any progress on this PR?

@Hat52
Copy link
Contributor Author

Hat52 commented Apr 1, 2023

Hello @Sachin-chaurasiya , I had an emergency
going on at home. Hope fully I will update it tomorrow

@Sachin-chaurasiya
Copy link
Member

Hello @Sachin-chaurasiya , I had an emergency going on at home. Hope fully I will update it tomorrow

No worries @Hat52, Take care.

@Hat52
Copy link
Contributor Author

Hat52 commented Apr 4, 2023

I am getting

✖ Prevented an empty git commit!

error from husky webhook. The suggestion says that I should add --allow-empty in my command.

Should I go with it or is there a better way?

@Sachin-chaurasiya
Copy link
Member

I am getting

✖ Prevented an empty git commit!

error from husky webhook. The suggestion says that I should add --allow-empty in my command.

Should I go with it or is there a better way?

Hello @Hat52 , Sorry for the late response, please take the latest pull and then try.
Also, if you are trying to make empty commit then it won't work.

@Hat52 Hat52 requested a review from anuj-kumary as a code owner April 15, 2023 20:06
@Hat52
Copy link
Contributor Author

Hat52 commented Apr 15, 2023

I have rebased this branch with main branch and pushed it. @Sachin-chaurasiya

@Sachin-chaurasiya
Copy link
Member

I have rebased this branch with main branch and pushed it. @Sachin-chaurasiya

Hello @Hat52, apologies for the late response. build is failing with this error can you fix it?
image

@Sachin-chaurasiya
Copy link
Member

Due to inactivity closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The "Copy URL" button on the home page is not necessary
2 participants