Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compare ToTheme in the theme selector #169

Open
labordep opened this issue Apr 6, 2024 · 6 comments
Open

Cannot compare ToTheme in the theme selector #169

labordep opened this issue Apr 6, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@labordep
Copy link
Member

labordep commented Apr 6, 2024

Exception : NotFound: [ :each | each model = anItem ] not found in OrderedCollection when I'm trying to edit a Toplo view into Pyramid.

image

@labordep labordep added the bug Something isn't working label Apr 6, 2024
@labordep
Copy link
Member Author

labordep commented Apr 6, 2024

This is major because I cannot edit Toplo view with theme!

@labordep
Copy link
Member Author

labordep commented Apr 6, 2024

@plantec says that it should be better to ask the Theme class and not the Theme instance.

@Nyan11
Copy link
Collaborator

Nyan11 commented Apr 10, 2024

It is true if we considere the theme as static. For example we do not dynamicly update token values

@labordep
Copy link
Member Author

That's why I prefer to implement "=" in Themes :)

@plantec
Copy link

plantec commented Apr 13, 2024

no = please.
now, token properties can be added dynamically in a theme.
@pierre, this is not that one should take the class. I said to store an instance in a class variable :)

@labordep
Copy link
Member Author

We can display the class name of the current Theme in the list and propose to setup another one using just class name comparison. We can reset the current Theme (in case of modifications) by a new one from the same class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants