Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User import: 'is_active' should have the default true #2579

Closed
Elblinator opened this issue Aug 20, 2024 · 4 comments · Fixed by #2597
Closed

User import: 'is_active' should have the default true #2579

Elblinator opened this issue Aug 20, 2024 · 4 comments · Fixed by #2597
Assignees
Labels
bug migration Introduces a new migration
Milestone

Comments

@Elblinator
Copy link
Member

Current behaviour:
If a user is created via the import and the cell in the is_active row was empty then the backend saved the value "null"

Wanted behaviour:
the new default should be true (every user who is created via the import should have is_active:true, if not explicitly stated otherwise

For the needed migration:
If a user was imported like described, then this user cannot login and they get the snackbar Error

Error: The account is deactivated.
@Elblinator Elblinator added bug migration Introduces a new migration labels Aug 20, 2024
@Elblinator Elblinator added this to the 4.2 milestone Aug 20, 2024
@Elblinator Elblinator added the waiting Waiting for some other PR/feature; more details in comments label Aug 20, 2024
@Elblinator
Copy link
Member Author

waiting for
OpenSlides/openslides-client#4011

@luisa-beerboom
Copy link
Member

So... should the migration just set every user with is_active==None to True?

@rrenkert
Copy link
Contributor

rrenkert commented Sep 5, 2024

@luisa-beerboom Yes, every user that has is_active==None should be set to true.

@rrenkert rrenkert removed the waiting Waiting for some other PR/feature; more details in comments label Sep 5, 2024
@rrenkert
Copy link
Contributor

rrenkert commented Sep 5, 2024

Wanted behaviour: the new default should be true (every user who is created via the import should have is_active:true, if not explicitly stated otherwise

The default should always be used not only in the import.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug migration Introduces a new migration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants