Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handoffs and bucket properties #22

Open
martinsumner opened this issue Jan 20, 2025 · 1 comment
Open

Handoffs and bucket properties #22

martinsumner opened this issue Jan 20, 2025 · 1 comment

Comments

@martinsumner
Copy link
Contributor

martinsumner commented Jan 20, 2025 •
edited
Loading

Repair handoffs do not work with n_val set via bucket types. It relies on the riak_kv_vnode:nval_map/1 which uses riak_core_bucket:bucket_nval_map/1 function - which only returns information about properties on buckets within the ring, not on typed buckets.

It also appears (still to be confirmed) that hinted handoffs may not work as expected when n_val is set via bucket properties (and not via types).
martinsumner referenced this issue in OpenRiak/riak_test-forked Jan 20, 2025
@martinsumner
Update tests for node repair
805d30b 
Prove repair on different nvals

Note https://github.com/OpenRiak/riak_kv/issues/62

This is fixed for bucket types - but doesn't work on n_val set on untyped buckets.
@martinsumner
Copy link
Contributor Author

Only other user of riak_kv_vnode:nval_map/1 is fold_extras_keys/2. However, this only appears to have a use in ring_resizing, and so is not a priority issue (given that ring resizing is deprecated, and never was officially supported).

@tburghart tburghart transferred this issue from OpenRiak/riak_kv-forked Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martinsumner