Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capability checks for very old capabilities #19

Open
martinsumner opened this issue Jan 10, 2025 · 1 comment
Open

Capability checks for very old capabilities #19

martinsumner opened this issue Jan 10, 2025 · 1 comment

Comments

@martinsumner
Copy link
Contributor

The riak_kv code has multiple capability checks (cluster-wide checks that all nodes support the capability) for capabilities that have existed since Riak 2.0 or before.

Capability checks are cheap, but not free. There are two capability checks in every encode_item call for handoff - so they may be called 1000s of times per second.

There has been anecdotal evidence of situations where during node failure events capability checks have reverted back to old capabilities - and then caused unexpected behaviour - in particular with the object_format capability check.

For 3.4 - we should sweep through these old capability checks and remove, default to the expected capability.

@martinsumner martinsumner changed the title Capability checks for very old capabilites Capability checks for very old capabilities Jan 10, 2025
@martinsumner
Copy link
Contributor Author

@tburghart tburghart transferred this issue from OpenRiak/riak_kv-forked Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant