SSL, dialyzer, applications

[martinsumner]

There have been issues related to dialyzer and the use of SSL in ibrowse.

There appears to be issues if:

• it is not referred to in app.src;
• Is added in applications;
• Is added to included_applications.

Adding it to applications (which was the last change), breaks the use of riak erlang http client in riak_test.

[martinsumner]

If there is no reference to ssl then OTP 26 dialyzer complains:

src/ibrowse_http_client.erl
Line 580 Column 13: Unknown function ssl:connect/4
Line 590 Column 21: Unknown function ssl:connect/3
Line 659 Column 57: Unknown function ssl:send/2
Line 746 Column 59: Unknown function ssl:close/1
Line 759 Column 50: Unknown function ssl:setopts/2
Line 1356 Column 10: Unknown function ssl:connect/3

Including it though causes issues where ssl is not started in tests.

[martinsumner]

The answer appears to be to include in applications and optional_applications